From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Julian Braha <julianbraha@gmail.com>,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
Vijendar.Mukunda@amd.com, AjitKumar.Pandey@amd.com,
kai.vehmanen@linux.intel.com, tanureal@opensource.cirrus.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
fazilyildiran@gmail.com
Subject: Re: [PATCH] ASoC: amd: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
Date: Tue, 18 Jan 2022 17:35:31 +0000 [thread overview]
Message-ID: <Yeb6YzIugFSmidQY@sirena.org.uk> (raw)
In-Reply-To: <26ec72a7-effa-7553-fc0f-4e016b651c09@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
On Tue, Jan 18, 2022 at 11:21:50AM -0600, Pierre-Louis Bossart wrote:
> On 1/18/22 11:10 AM, Mark Brown wrote:
> > Why is this a good fix and not removing the dependency on gpiolib from
> > DMIC? While a DMIC *can* use a GPIO it's not something that's an
> > intrinsic requirement and it's entirely optional in the code.
> We also have similar 'depends on GPIOLIB' for Intel boards that are not
> really useful. see e.g. 4262ddc2ad63 ('ASoC: Intel: boards: add explicit
> dependency on GPIOLIB when DMIC is used'). IIRC we had this discussion
> before about doing a larger cleanup.
At first glance it's just that the gpiolib dependency on the DMIC driver
is spurious and should be deleted, the code looks fine and I'd not
expect any need for an actual dependency (but I'm out of office this
week so probably not going to actually poke at things properly right
now).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-01-18 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 4:15 Julian Braha
2022-01-18 17:10 ` Mark Brown
2022-01-18 17:21 ` Pierre-Louis Bossart
2022-01-18 17:35 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yeb6YzIugFSmidQY@sirena.org.uk \
--to=broonie@kernel.org \
--cc=AjitKumar.Pandey@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=fazilyildiran@gmail.com \
--cc=julianbraha@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®