From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835F6C433F5 for ; Wed, 19 Jan 2022 17:37:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356384AbiASRhq (ORCPT ); Wed, 19 Jan 2022 12:37:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352552AbiASRho (ORCPT ); Wed, 19 Jan 2022 12:37:44 -0500 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6D9FC061574; Wed, 19 Jan 2022 09:37:43 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0DB601C000B; Wed, 19 Jan 2022 17:37:40 +0000 (UTC) Date: Wed, 19 Jan 2022 18:37:40 +0100 From: Alexandre Belloni To: Hugo Villeneuve Cc: Alessandro Zummo , Hugo Villeneuve , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: pcf2127: add error message if writing to CLKOUT register fails Message-ID: References: <20220119172740.1856302-1-hugo@hugovil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220119172740.1856302-1-hugo@hugovil.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/01/2022 12:27:39-0500, Hugo Villeneuve wrote: > From: Hugo Villeneuve > > If writing to CLKOUT register fails, the probe operation will be aborted > without a meaningful error message. > The current trend is to remove debug messages, please do not add more :) > Signed-off-by: Hugo Villeneuve > --- > drivers/rtc/rtc-pcf2127.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c > index 3d1f57e54372..823abe2a7147 100644 > --- a/drivers/rtc/rtc-pcf2127.c > +++ b/drivers/rtc/rtc-pcf2127.c > @@ -717,8 +717,10 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap, > if (!(val & PCF2127_BIT_CLKOUT_OTPR)) { > ret = regmap_set_bits(pcf2127->regmap, PCF2127_REG_CLKOUT, > PCF2127_BIT_CLKOUT_OTPR); > - if (ret < 0) > + if (ret < 0) { > + dev_err(dev, "writing to CLKOUT register failed\n"); > return ret; > + } > > msleep(100); > } > -- > 2.30.2 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com