From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E83FAC4167B for ; Wed, 19 Jan 2022 19:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239367AbiASTSU (ORCPT ); Wed, 19 Jan 2022 14:18:20 -0500 Received: from mga07.intel.com ([134.134.136.100]:3778 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbiASTSN (ORCPT ); Wed, 19 Jan 2022 14:18:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642619893; x=1674155893; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=kxRfIA4D62784M70rCIvvyS5N+0IFzqyS/xs1UeIcLQ=; b=JsrTTmwRI6CKWZJ2CS2EPZNo78q+ZTqjXk2EuajVWVzEWaAwo6RB8Y2z p2q9PqGToDTUKnC+20lv+CIeQWBQXrWVoAu+66tbDUCDD2kVimNcmi+o1 NI4uUv2QzLLWoxZwGqYce838fGV25siRy7TkCtV0kEjntqXFMVq5KkxkO Qypx2zj4CEq2cNbQdX5t0VuYkYsO/VxT6QMsGmF082dWEiGGwNdFTNTbX PfDUm/IwzNOuRH71jXP7iAuDLexE1zsCCvdFAmMndcXpk+OJbcIB3Rfpz aTAvP/lyeSwJWCuLsJkR1IYry0wPAsSHazovH/AdnE+nf2AI+fzjcT7zX g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="308502424" X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="308502424" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:52:59 -0800 X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="672273577" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:52:42 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nAG3N-00CE3S-Uj; Wed, 19 Jan 2022 20:51:29 +0200 Date: Wed, 19 Jan 2022 20:51:29 +0200 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , KVM list , "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , ALSA Development Mailing List , Jaroslav Kysela , Guenter Roeck , Thierry Reding , MTD Maling List , Linux I2C , "open list:GPIO SUBSYSTEM" , Miquel Raynal , linux-phy@lists.infradead.org, netdev@vger.kernel.org, linux-spi , Jiri Slaby , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Kamal Dasu , Lee Jones , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , Geert Uytterhoeven , "open list:SERIAL DRIVERS" , bcm-kernel-feedback-list , Zhang Rui , platform-driver-x86@vger.kernel.org, Linux PWM List , Robert Richter , Saravanan Sekar , Corey Minyard , Linux PM list , Liam Girdwood , John Garry , Takashi Iwai , Peter Korsgaard , William Breathitt Gray , Mark Gross , Hans de Goede , Alex Williamson , Mark Brown , Borislav Petkov , Jakub Kicinski , Matthias Brugger , openipmi-developer@lists.sourceforge.net, Mauro Carvalho Chehab , Benson Leung , Pengutronix Kernel Team , Linux ARM , linux-edac@vger.kernel.org, Tony Luck , Richard Weinberger , Mun Yew Tham , Eric Auger , Greg Kroah-Hartman , Yoshihiro Shimoda , Cornelia Huck , Linux MMC List , Joakim Zhang , Linux Kernel Mailing List , Linux-Renesas , Sergey Shtylyov , Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , "David S. Miller" Subject: Re: [PATCH] driver core: platform: Rename platform_get_irq_optional() to platform_get_irq_silent() Message-ID: References: <20220112085009.dbasceh3obfok5dc@pengutronix.de> <20220112213121.5ruae5mxwj6t3qiy@pengutronix.de> <20220113110831.wvwbm75hbfysbn2d@pengutronix.de> <20220113194358.xnnbhsoyetihterb@pengutronix.de> <20220115154539.j3tsz5ioqexq2yuu@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220115154539.j3tsz5ioqexq2yuu@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 15, 2022 at 04:45:39PM +0100, Uwe Kleine-König wrote: > On Fri, Jan 14, 2022 at 03:04:38PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 13, 2022 at 08:43:58PM +0100, Uwe Kleine-König wrote: > > > > It'd certainly be good to name anything that doesn't correspond to one > > > > of the existing semantics for the API (!) something different rather > > > > than adding yet another potentially overloaded meaning. > > > > > > It seems we're (at least) three who agree about this. Here is a patch > > > fixing the name. > > > > And similar number of people are on the other side. > > If someone already opposed to the renaming (and not only the name) I > must have missed that. > > So you think it's a good idea to keep the name > platform_get_irq_optional() despite the "not found" value returned by it > isn't usable as if it were a normal irq number? I meant that on the other side people who are in favour of Sergey's patch. Since that I commented already that I opposed the renaming being a standalone change. Do you agree that we have several issues with platform_get_irq*() APIs? 1. The unfortunate naming 2. The vIRQ0 handling: a) WARN() followed by b) returned value 0 3. The specific cookie for "IRQ not found, while no error happened" case -- With Best Regards, Andy Shevchenko