From: Andi Shyti <andi@etezian.org>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski@canonical.com,
linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com,
broonie@kernel.org, andi@etezian.org, linux-spi@vger.kernel.org,
linux-fsd@tesla.com, Aswani Reddy <aswani.reddy@samsung.com>
Subject: Re: [PATCH v2 2/3] spi: s3c64xx: Add spi port configuration for Tesla FSD SoC
Date: Sat, 22 Jan 2022 12:32:30 +0200 [thread overview]
Message-ID: <YevdPslZ//gylbGX@jack.zhora.eu> (raw)
In-Reply-To: <20220120192438.25555-3-alim.akhtar@samsung.com>
Hi Alim,
> Adds compatible and port configuration for spi controller
> for Tesla Full Self-Driving SoC.
please next time be a bit clearer in the cover letter. I think
you want to say:
"This patch adds the compatible..."
But it's anyway recommended to use the imperative form:
"Add the compatible blah blah blah...."
> Cc: linux-fsd@tesla.com
> Signed-off-by: Aswani Reddy <aswani.reddy@samsung.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Other than that, looks good to me:
Reviewed-by: Andi Shyti <andi@etezian.org>
Thanks,
Andi
next prev parent reply other threads:[~2022-01-22 11:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220120193608epcas5p466c73dfdcc7eb5cdcd52516a635fca79@epcas5p4.samsung.com>
2022-01-20 19:24 ` [PATCH v2 0/3] Add FSD SPI support Alim Akhtar
[not found] ` <CGME20220120193613epcas5p238851849d212e01d7d830d78ca7d6379@epcas5p2.samsung.com>
2022-01-20 19:24 ` [PATCH v2 1/3] spi: dt-bindings: samsung: Add fsd spi compatible Alim Akhtar
2022-01-21 18:33 ` Krzysztof Kozlowski
2022-01-22 10:28 ` Andi Shyti
2022-01-22 10:33 ` Krzysztof Kozlowski
2022-01-21 18:34 ` Krzysztof Kozlowski
[not found] ` <CGME20220120193618epcas5p45be1db500363072e647bf179623f8e7a@epcas5p4.samsung.com>
2022-01-20 19:24 ` [PATCH v2 2/3] spi: s3c64xx: Add spi port configuration for Tesla FSD SoC Alim Akhtar
2022-01-21 18:33 ` Krzysztof Kozlowski
2022-01-22 10:32 ` Andi Shyti [this message]
[not found] ` <CGME20220120193622epcas5p3a65c8424c6a01aed9a87f5ac2a89eb06@epcas5p3.samsung.com>
2022-01-20 19:24 ` [PATCH v2 3/3] arm64: dts: fsd: Add SPI device nodes Alim Akhtar
2022-01-22 10:42 ` Andi Shyti
2022-01-24 17:00 ` Alim Akhtar
2022-03-08 20:09 ` (subset) [PATCH v2 0/3] Add FSD SPI support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YevdPslZ//gylbGX@jack.zhora.eu \
--to=andi@etezian.org \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®