From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C61DFC433FE for ; Sat, 5 Feb 2022 04:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379424AbiBEEem (ORCPT ); Fri, 4 Feb 2022 23:34:42 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:34050 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379416AbiBEEek (ORCPT ); Fri, 4 Feb 2022 23:34:40 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1nGCmK-0002CH-S2; Sat, 05 Feb 2022 15:34:30 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sat, 05 Feb 2022 15:34:28 +1100 Date: Sat, 5 Feb 2022 15:34:28 +1100 From: Herbert Xu To: Colin Ian King Cc: Corentin Labbe , Hans Ulli Kroll , Linus Walleij , "David S . Miller" , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: sl3516: remove redundant initializations of pointers in_sg and out_sg Message-ID: References: <20220130230515.8338-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220130230515.8338-1-colin.i.king@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 30, 2022 at 11:05:15PM +0000, Colin Ian King wrote: > Pointers in_sg and out_sg are being initialized with values that are > never read, they are being re-assigned the same values later on. The > initializations are redundant, remove them in preference to the later > assignments that are closer to when the pointers are being used. > > Signed-off-by: Colin Ian King > --- > drivers/crypto/gemini/sl3516-ce-cipher.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt