From: Herbert Xu <herbert@gondor.apana.org.au>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: engine: disable BH during completion
Date: Sat, 5 Feb 2022 15:03:11 +1100 [thread overview]
Message-ID: <Yf32/7Vi/Y7VtE3/@gondor.apana.org.au> (raw)
In-Reply-To: <20220127133332.4011509-1-clabbe@baylibre.com>
On Thu, Jan 27, 2022 at 01:33:32PM +0000, Corentin Labbe wrote:
> When doing iperf over ipsec with crypto hardware sun8i-ce, I hit some
> spinlock recursion bug.
>
> This is due to crypto/crypto_engine not disabling BH when calling
> completion function.
>
> Fixes: 735d37b5424b ("crypto: engine - Introduce the block request crypto engine framework")
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> crypto/crypto_engine.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/crypto/crypto_engine.c b/crypto/crypto_engine.c
> index fb07da9920ee..b3844f6d98a3 100644
> --- a/crypto/crypto_engine.c
> +++ b/crypto/crypto_engine.c
> @@ -7,6 +7,7 @@
> * Author: Baolin Wang <baolin.wang@linaro.org>
> */
>
> +#include <linux/bottom_half.h>
> #include <linux/err.h>
> #include <linux/delay.h>
> #include <linux/device.h>
> @@ -53,7 +54,9 @@ static void crypto_finalize_request(struct crypto_engine *engine,
> dev_err(engine->dev, "failed to unprepare request\n");
> }
> }
> + local_bh_disable();
> req->complete(req, err);
> + local_bh_enable();
Most other drivers call this function in softirq context. In
general crypto API callback functions expect to be called in softirq
context.
So I think we should fix the driver to do the bh disable instead.
However, it's probably a good idea to add a check in this spot to
detect drivers that are calling this in the wrong context, e.g.,
lockdep_assert_in_softirq().
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2022-02-05 4:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 13:33 Corentin Labbe
2022-02-05 4:03 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf32/7Vi/Y7VtE3/@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®