From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alfasys <alfred@alfasys.se>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Damian Hobson-Garcia <dhobsong@igel.co.jp>
Subject: Re: [PATCH 001/001] UIO: allow binding uio_dmem_genirq to devices using command line options
Date: Wed, 26 Jan 2022 19:02:26 +0100 [thread overview]
Message-ID: <YfGMsujnTxIxlXp4@kroah.com> (raw)
In-Reply-To: <qFul607Amxy21SnrHljzWlk1zF1aanKgSpEIH0--hvj9t9wRzQR5xx80eFgl_2I6pppi8NNFp0TTHwkQw0uQD0Xl-8vth8-KOsbfwrLIHNg=@alfasys.se>
On Sat, Jan 15, 2022 at 04:42:02PM +0000, Alfasys wrote:
> Add an option to bind the uio_dmem_genirq driver to a given device
> using command line options.
> Make uio_dmem_genirq match uio_pdrv_genirq functionality added in
> commit 05c3e0bb5629 ("UIO: allow binding uio_pdrv_genirq.c to devices
>
> using command line option")
>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Damian Hobson-Garcia <dhobsong@igel.co.jp>
> Signed-off-by: Alfred Patriksson <alfred@alfasys.se>
>
> ---
>
> git diff c9e6606c7fe92 #(tag: v5.16-rc8)
> diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
> index 6b5cfa5b0673..7f6c9b594dd4 100644
> --- a/drivers/uio/uio_dmem_genirq.c
> +++ b/drivers/uio/uio_dmem_genirq.c
> @@ -317,10 +317,13 @@ static const struct dev_pm_ops uio_dmem_genirq_dev_pm_ops = {
> };
>
>
> #ifdef CONFIG_OF
> -static const struct of_device_id uio_of_genirq_match[] = {
> - { /* empty for now */ },
> +static struct of_device_id uio_of_genirq_match[] = {
> + { /* This is filled with module_parm */ },
> + { /* Sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
> +module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
> +MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
I do not want to add new module parameters, this is not the 1990's
anymore.
thanks,
greg k-h
prev parent reply other threads:[~2022-01-26 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 16:42 Alfasys
2022-01-18 6:51 ` Damian Hobson-Garcia
2022-01-26 18:02 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfGMsujnTxIxlXp4@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alfred@alfasys.se \
--cc=dhobsong@igel.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®