From: Greg KH <gregkh@linuxfoundation.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/1] usbnet: add devlink support
Date: Thu, 27 Jan 2022 12:19:38 +0100 [thread overview]
Message-ID: <YfJ/yjPdbvKHKXI6@kroah.com> (raw)
In-Reply-To: <20220127110742.922752-1-o.rempel@pengutronix.de>
On Thu, Jan 27, 2022 at 12:07:42PM +0100, Oleksij Rempel wrote:
> +static int usbnet_devlink_info_get(struct devlink *devlink,
> + struct devlink_info_req *req,
> + struct netlink_ext_ack *extack)
> +{
> + struct usbnet *usbnet = usbnet_from_devlink(devlink);
> + char buf[10];
> + int err;
> +
> + err = devlink_info_driver_name_put(req, KBUILD_MODNAME);
> + if (err)
> + return err;
> +
> + scnprintf(buf, 10, "%d.%d", 100, 200);
Odd magic number values :(
next prev parent reply other threads:[~2022-01-27 11:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 11:07 Oleksij Rempel
2022-01-27 11:13 ` Greg KH
2022-01-27 12:31 ` Oleksij Rempel
2022-01-27 13:22 ` Greg KH
2022-01-28 11:12 ` Oleksij Rempel
2022-01-28 11:23 ` Greg KH
2022-01-28 11:31 ` Oleksij Rempel
2022-02-02 9:14 ` Oliver Neukum
2022-01-27 17:00 ` Alan Stern
2022-01-28 11:27 ` Oleksij Rempel
2022-01-28 15:33 ` Alan Stern
2022-01-27 11:18 ` Greg KH
2022-01-27 11:19 ` Greg KH [this message]
2022-01-27 15:43 ` Andrew Lunn
2022-01-27 16:56 ` Jakub Kicinski
2022-01-27 19:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfJ/yjPdbvKHKXI6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®