From: "hch@infradead.org" <hch@infradead.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Yang Shi <shy828301@gmail.com>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"hch@infradead.org" <hch@infradead.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>
Subject: Re: [v5 PATCH] block: introduce block_rq_error tracepoint
Date: Thu, 27 Jan 2022 01:52:07 -0800 [thread overview]
Message-ID: <YfJrR7nIw0fbHLVj@infradead.org> (raw)
In-Reply-To: <8de293cb-168b-5a52-3791-dba36ef4217d@nvidia.com>
On Thu, Jan 27, 2022 at 08:02:26AM +0000, Chaitanya Kulkarni wrote:
> > + __field( unsigned int, nr_sector )
> > + __field( int, error )
> > + __array( char, rwbs, RWBS_LEN )
> > + ),
> > +
> > + TP_fast_assign(
> > + __entry->dev = rq->q->disk ? disk_devt(rq->q->disk) : 0;
> > + __assign_str(name, rq->q->disk ? rq->q->disk->disk_name : "?");
>
> Did you verify that rq->q->disk NULL checks are must in this checkout
> for blk_update_request() ?
Yes, we need this.
next prev parent reply other threads:[~2022-01-27 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 18:51 Yang Shi
2022-01-27 8:02 ` Chaitanya Kulkarni
2022-01-27 9:52 ` hch [this message]
2022-01-27 18:18 ` Yang Shi
2022-01-27 9:53 ` Christoph Hellwig
2022-01-27 18:18 ` Yang Shi
2022-02-02 17:47 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfJrR7nIw0fbHLVj@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shy828301@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome