From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC352C433FE for ; Thu, 27 Jan 2022 15:36:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238070AbiA0Pgh (ORCPT ); Thu, 27 Jan 2022 10:36:37 -0500 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]:41591 "EHLO wnew1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237659AbiA0Pgf (ORCPT ); Thu, 27 Jan 2022 10:36:35 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 602D22B000EF; Thu, 27 Jan 2022 10:36:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 27 Jan 2022 10:36:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=MM3mlkgPNz3VRanbe6Q2yF8PwWWepcvoMK3Gfx hgWQs=; b=P2YQ8gi+Lu9QFkGb5ntAXFjxYQyHkFcM9oLOuKOo3uYqntdqgXi9+w NRAHIcF3yeMynrermh13Zfu+wxYNYQ6GbI1tmPrI7UxS8W6eKx7akBmr7FqqXOe3 cPaFA+WocVMqf+3n8/nU1MKO6di/QioQ11RaP1e7JIJ2n4vuDhlQ3ZIJxvYe0PtG ywUNjwb2+M2AChhmiQZQe8AZeQh0MFCgjBTygURKRpX3b8nlKjj7ZktSYHBOG2oT pL4Kp6oVTlOqlVEcuRwg9TRMLrdZvZfaoJT4KjSSoLyFL3j6sV8bdOEG/KpO2ai2 tDLIQkHFbQeZHOdkeAa3OAnQ3SgUMJzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=MM3mlkgPNz3VRanbe 6Q2yF8PwWWepcvoMK3GfxhgWQs=; b=k5s14h60VAO9d7lRux0hmyLpKCkELrhQr 0feRYcYkI8gSlWOUh5z5wg4MBcVdoRlgQ8xKWQdsvZ79swSemahTM1Zx2y7Icw6p LbgCVFEJbvbbhJmCM4/ra7/s+AVy0l0aP5UqMpPKAtdKhytoq0XpYg+ErBw+Y3vQ MwGyVXMs/bfibdKOT5aoIbJ7TPsPtp/nmgda40BoxFhjlT3xk3xJ3msg9x4Bmkvp Ku46z6O3dw2RZ2ZwIc5G+lELDVWgkvy/BMo3hxyXaNIgpDuYb1y+VmkBijTftYjr N1Np2u4RUxadnAQjBd+Pn+bPahB8pJRgOsLoWtJxfEFoGcIsYrXLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrfeefgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghgucfm jfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuheejgf ffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrd gtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Jan 2022 10:36:32 -0500 (EST) Date: Thu, 27 Jan 2022 16:36:30 +0100 From: Greg KH To: Anders Roxell Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, Stefan Agner , Arnd Bergmann , Russell King Subject: Re: [4.9 PATCH] ARM: 8800/1: use choice for kernel unwinders Message-ID: References: <20220125134148.3390940-1-anders.roxell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220125134148.3390940-1-anders.roxell@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 25, 2022 at 02:41:48PM +0100, Anders Roxell wrote: > From: Stefan Agner > > commit f9b58e8c7d031b0daa5c9a9ee27f5a4028ba53ac upstream. > > While in theory multiple unwinders could be compiled in, it does > not make sense in practise. Use a choice to make the unwinder > selection mutually exclusive and mandatory. > > Already before this commit it has not been possible to deselect > FRAME_POINTER. Remove the obsolete comment. > > Furthermore, to produce a meaningful backtrace with FRAME_POINTER > enabled the kernel needs a specific function prologue: > mov ip, sp > stmfd sp!, {fp, ip, lr, pc} > sub fp, ip, #4 > > To get to the required prologue gcc uses apcs and no-sched-prolog. > This compiler options are not available on clang, and clang is not > able to generate the required prologue. Make the FRAME_POINTER > config symbol depending on !clang. > > Suggested-by: Arnd Bergmann > Signed-off-by: Stefan Agner > Reviewed-by: Arnd Bergmann > Signed-off-by: Russell King > Signed-off-by: Anders Roxell > --- > arch/arm/Kconfig.debug | 44 +++++++++++++++++++++++++++--------------- > lib/Kconfig.debug | 6 +++--- > 2 files changed, 31 insertions(+), 19 deletions(-) Now queued up, thanks. greg k-h