From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F4DC433EF for ; Thu, 27 Jan 2022 13:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240051AbiA0N4h (ORCPT ); Thu, 27 Jan 2022 08:56:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236903AbiA0N4g (ORCPT ); Thu, 27 Jan 2022 08:56:36 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55595C061714 for ; Thu, 27 Jan 2022 05:56:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E9AD+rI9OWKW7gBQjNlVOBV7o12pc2DPP2BjIJ5a0lU=; b=Sy4LpHlXX/F9DEhym1b6Z0CR3S v10GUiwrWU1FvDB99woTbeQ5iQmOuEixU8lKbEW9QoKv+3yZZNmmUkXgQffWsdoR+KD/4Ev1bwxMT M23P2Kp+z6rzjk0oHl9sDzenaBABKh4Y+9UGwga8G7DS5LISN/MeAbGwqz7m1LVlKlC/NN2DeEkro WbJtd/JtgfiGkWnc9sDKRGFodbdRdhdKU6mNbck7cBN4oI1c/2C7hYtVcQuVX01kbNhzIR6hHBC2v ku1W88LcrSLyAfrBy08bgozzv3w/hhwhtlP201NYXvy9U8lrW7jIiNV3NVrdyAT5+2StI3Gh50hhH Et2Vs09Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD5GL-005I3G-RO; Thu, 27 Jan 2022 13:56:33 +0000 Date: Thu, 27 Jan 2022 13:56:33 +0000 From: Matthew Wilcox To: Karolina Drobnik Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/16] tools/include: Update atomic.h header Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 02:21:22PM +0100, Karolina Drobnik wrote: > Add atomic_long_t typedef and atomic_long_set function so they > can be used in testing. > > Signed-off-by: Karolina Drobnik > --- > tools/include/linux/atomic.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/include/linux/atomic.h b/tools/include/linux/atomic.h > index 00a6c4ca562b..5d2431889606 100644 > --- a/tools/include/linux/atomic.h > +++ b/tools/include/linux/atomic.h > @@ -4,6 +4,10 @@ > > #include > > +typedef atomic_t atomic_long_t; Given this: typedef struct { int counter; } atomic_t; your definition seems wrong. Why not add atomic_long_t to types.h, adjacent to atomic_t?