From: Andrew Lunn <andrew@lunn.ch>
To: cgel.zte@gmail.com
Cc: jiri@resnulli.us, ivecera@redhat.com, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] net/switchdev: use struct_size over open coded arithmetic
Date: Fri, 28 Jan 2022 19:19:22 +0100 [thread overview]
Message-ID: <YfQzqqiw7O/iKUD0@lunn.ch> (raw)
In-Reply-To: <20220128075729.1211352-1-chi.minghao@zte.com.cn>
On Fri, Jan 28, 2022 at 07:57:29AM +0000, cgel.zte@gmail.com wrote:
> From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>
>
> Replace zero-length array with flexible-array member and make use
> of the struct_size() helper in kmalloc(). For example:
>
> struct switchdev_deferred_item {
> ...
> unsigned long data[];
> };
>
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
Please could you train your bot to zealously compile test patches
before submitting them?
At the moment you seem to have more patches which fail to build then
actually build. So you are wasting peoples time, which is not going to
make Maintainers happy.
Andrew
prev parent reply other threads:[~2022-01-28 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 7:57 cgel.zte
2022-01-28 12:40 ` kernel test robot
2022-01-28 17:06 ` kernel test robot
2022-01-28 18:19 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfQzqqiw7O/iKUD0@lunn.ch \
--to=andrew@lunn.ch \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®