mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Andreas Kemnade <andreas@kemnade.info>,
	linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v4 1/4] math.h: Introduce data types for fractional numbers
Date: Mon, 31 Jan 2022 12:17:44 +0200	[thread overview]
Message-ID: <Yfe3SK88LeJ8Iebf@smile.fi.intel.com> (raw)
In-Reply-To: <20220130123034.708543ad@jic23-huawei>

On Sun, Jan 30, 2022 at 12:30:47PM +0000, Jonathan Cameron wrote:
> On Wed, 26 Jan 2022 15:53:50 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Introduce a macro to produce data types like
> > 
> > 	struct TYPE_fract {
> > 		__TYPE numerator;
> > 		__TYPE denominator;
> > 	};
> > 
> > to be used in the code wherever it's needed.
> > 
> > In the following changes convert some users to it.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> I'm not 100% sold on this, but I'm going to give them the benefit
> of the doubt as to long term usefulness and apply them.
> 
> Basically I'm taking the view Andy is often right :)

Time will show :-)

> Applied to the togreg branch of iio.git and pushed out as testing
> for 0-day to see if we missed anything.

Thanks!

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2022-01-31 10:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 13:53 Andy Shevchenko
2022-01-26 13:53 ` [PATCH v4 2/4] iio: adc: rn5t618: Re-use generic struct u16_fract Andy Shevchenko
2022-01-26 13:53 ` [PATCH v4 3/4] iio: adc: twl4030-madc: Re-use generic struct s16_fract Andy Shevchenko
2022-01-26 13:53 ` [PATCH v4 4/4] iio: adc: qcom-vadc-common: Re-use generic struct u32_fract Andy Shevchenko
2022-01-26 14:12 ` [PATCH v4 1/4] math.h: Introduce data types for fractional numbers Andy Shevchenko
2022-01-30 12:30 ` Jonathan Cameron
2022-01-31 10:17   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yfe3SK88LeJ8Iebf@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=agross@kernel.org \
    --cc=andreas@kemnade.info \
    --cc=bjorn.andersson@linaro.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome