From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2721EC433EF for ; Tue, 1 Feb 2022 23:39:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242913AbiBAXjz (ORCPT ); Tue, 1 Feb 2022 18:39:55 -0500 Received: from mail-oi1-f181.google.com ([209.85.167.181]:42796 "EHLO mail-oi1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbiBAXjy (ORCPT ); Tue, 1 Feb 2022 18:39:54 -0500 Received: by mail-oi1-f181.google.com with SMTP id v67so36520761oie.9; Tue, 01 Feb 2022 15:39:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OQTTLf8kyfb5UwqPhCNrDroHE+/FDw4cB4fcGA5iy3A=; b=ySxuYzwxq1yqPiz/pWSIDOp0Z03vtRxKVyX7KSSc/CtFM7KZZjC/m7fFoPMxUTcBVE K/iyMQr5TmKIonBeZdhGbpAa234sb/bgCDrdR0uLsFZS0uwn1BH4SWifJcj4KFfJCezA 8B3gyS11JVcLWhMX5CKIRbG2fQ24LjZXmXsq1Yp/CvkvyX7KbRKNnZxUgMt3W2A+XH4Z fUNpC9R5foELOjkVPQCoXeYrG3m2pDKtHiHrXnoQCa9pUD1WY+jHKO8sxLgd6XKWPVsz A2z/HX0Q7lQVmmceF5dF5Our8zSizh61y1g2eGS5bz18H8+KrsWCz6piI4itYW0HFfmw 6aEQ== X-Gm-Message-State: AOAM531oa892RMmZ06+DOT09kzzSCfGkIWtFNsnv62gcrXB54igAF+xa GNifu0R9/zIsLspOrRDN08LWPY1cug== X-Google-Smtp-Source: ABdhPJwMgJEUGbtkBhJ1gxMnlJ0kD6R/QjV+sZxQmIAlKteFcFF0G42vTA4LVkTnvLRJDBKq4ylqNg== X-Received: by 2002:a05:6808:e81:: with SMTP id k1mr2927611oil.214.1643758793867; Tue, 01 Feb 2022 15:39:53 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id w20sm14694490otu.12.2022.02.01.15.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 15:39:52 -0800 (PST) Received: (nullmailer pid 980162 invoked by uid 1000); Tue, 01 Feb 2022 23:39:52 -0000 Date: Tue, 1 Feb 2022 17:39:52 -0600 From: Rob Herring To: David Brazdil Cc: Arnd Bergmann , Frank Rowand , Will Deacon , Andrew Scull , Wedson Almeida Filho , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v7 1/2] dt-bindings: reserved-memory: Open Profile for DICE Message-ID: References: <20220126231237.529308-1-dbrazdil@google.com> <20220126231237.529308-2-dbrazdil@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 26, 2022 at 11:19:08PM +0000, David Brazdil wrote: > Hi Rob, > > On Wed, Jan 26, 2022 at 11:12:36PM +0000, David Brazdil wrote: > > Add DeviceTree bindings for Open Profile for DICE, an open protocol for > > measured boot. Firmware uses DICE to measure the hardware/software > > combination and generates Compound Device Identifier (CDI) certificates. > > These are stored in memory and the buffer is described in the DT as > > a reserved memory region compatible with 'google,open-dice'. > > > > 'no-map' is required to ensure the memory region is never treated by > > the kernel as system memory. > > > > Signed-off-by: David Brazdil > > --- > > .../reserved-memory/google,open-dice.yaml | 46 +++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/reserved-memory/google,open-dice.yaml > > > > diff --git a/Documentation/devicetree/bindings/reserved-memory/google,open-dice.yaml b/Documentation/devicetree/bindings/reserved-memory/google,open-dice.yaml > > new file mode 100644 > > index 000000000000..257a0b51994a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/reserved-memory/google,open-dice.yaml > > @@ -0,0 +1,46 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/reserved-memory/google,open-dice.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Open Profile for DICE Device Tree Bindings > > + > > +description: | > > + This binding represents a reserved memory region containing data > > + generated by the Open Profile for DICE protocol. > > + > > + See https://pigweed.googlesource.com/open-dice/ > > + > > +maintainers: > > + - David Brazdil > > + > > +allOf: > > + - $ref: "reserved-memory.yaml" > > + > > +properties: > > + compatible: > > + const: google,open-dice > > + > > + reg: > > + description: page-aligned region of memory containing DICE data > > + > > +required: > > + - compatible > > + - reg > > + - no-map > > You already gave this a Reviewed-by in v6. Just want to mention that I > didn't pick it up because I added a required no-map here. It was always > included in our DTs but I made it required because the kernel should > never treat that region as system memory. The kernel will warn when the > driver tries to wipe the memory otherwise. That's small enough change to keep tags. Reviewed-by: Rob Herring