mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jordy Zomer <jordy@pwning.systems>
Cc: linux-kernel@vger.kernel.org, Oded Gabbay <ogabbay@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, Ofir Bitton <obitton@habana.ai>,
	Dani Liberman <dliberman@habana.ai>,
	Omer Shpigelman <oshpigelman@habana.ai>,
	Sagiv Ozeri <sozeri@habana.ai>,
	Yuri Nudelman <ynudelman@habana.ai>,
	farah kassabri <fkassabri@habana.ai>,
	Koby Elbaz <kelbaz@habana.ai>
Subject: Re: [PATCHv2] habanalabs: fix potential spectre v1 gadgets
Date: Wed, 2 Feb 2022 20:02:19 +0100	[thread overview]
Message-ID: <YfrVOylHQYqjiWJ5@kroah.com> (raw)
In-Reply-To: <20220202171931.3525220-1-jordy@pwning.systems>

On Wed, Feb 02, 2022 at 06:19:24PM +0100, Jordy Zomer wrote:
> It appears like nr could be a Spectre v1 gadget as it's supplied by a
> user and used as an array index. Prevent the contents
> of kernel memory from being leaked to userspace via speculative
> execution by using array_index_nospec.

Can you wrap your lines in a standard way?


> 
> Thanks for noticing Oded, made the changes.

This line should not be in the changelog :(

thanks,

greg k-h

  reply	other threads:[~2022-02-02 19:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 17:24 [PATCH] " Jordy Zomer
2022-02-02  7:50 ` Oded Gabbay
2022-02-02 10:22   ` Oded Gabbay
2022-02-02 17:19     ` [PATCHv2] " Jordy Zomer
2022-02-02 19:02       ` Greg Kroah-Hartman [this message]
2022-02-02 19:11         ` [PATCHv3] " Jordy Zomer
2022-02-02 19:13           ` Jordy Zomer
2022-02-02 21:01           ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfrVOylHQYqjiWJ5@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=dliberman@habana.ai \
    --cc=fkassabri@habana.ai \
    --cc=jordy@pwning.systems \
    --cc=kelbaz@habana.ai \
    --cc=linux-kernel@vger.kernel.org \
    --cc=obitton@habana.ai \
    --cc=ogabbay@kernel.org \
    --cc=oshpigelman@habana.ai \
    --cc=sozeri@habana.ai \
    --cc=ynudelman@habana.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®