From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Cc: dave.stevenson@raspberrypi.com, devicetree@vger.kernel.org,
kernel-list@raspberrypi.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org, lukasz@jany.st,
mchehab@kernel.org, naush@raspberrypi.com, robh@kernel.org,
tomi.valkeinen@ideasonboard.com
Subject: Re: [RFC PATCH v3 01/11] media: v4l: Add V4L2-PIX-FMT-Y12P format
Date: Wed, 2 Feb 2022 23:06:00 +0200 [thread overview]
Message-ID: <YfryOKmX+Qc6WYce@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220202175639.149681-2-jeanmichel.hautbois@ideasonboard.com>
Hi Jean-Michel,
On Wed, Feb 02, 2022 at 06:56:29PM +0100, Jean-Michel Hautbois wrote:
> This is a packed grey-scale image format with a depth of 12 bits per
> pixel. Two consecutive pixels are packed into 3 bytes. The first 2 bytes
> contain the 8 high order bits of the pixels, and the 3rd byte contains
> the 4 least significants bits of each pixel, in the same order.
>
> Add the entry in userspace API, and document it.
I only see documentation. At a quick glance this is caused by rebasing
on top of the ISP support. Don't. Please rebase this correctly on top of
linux-media/master with *only* the V4L2 streams series added to it, and
send a v4. I'll skip review of v3.
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../userspace-api/media/v4l/pixfmt-yuv-luma.rst | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst
> index 8ebd58c3588f..d37ce6027095 100644
> --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst
> @@ -92,6 +92,17 @@ are often referred to as greyscale formats.
> - ...
> - ...
>
> + * .. _V4L2-PIX-FMT-Y12P:
> +
> + - ``V4L2_PIX_FMT_Y12P``
> + - 'Y12P'
> +
> + - Y'\ :sub:`0`\ [11:4]
> + - Y'\ :sub:`1`\ [11:4]
> + - Y'\ :sub:`1`\ [3:0] Y'\ :sub:`0`\ [3:0]
> + - ...
> + - ...
> +
> * .. _V4L2-PIX-FMT-Y14:
>
> - ``V4L2_PIX_FMT_Y14``
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-02-02 21:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 17:56 [RFC PATCH v3 00/11] Add support for BCM2835 camera interface (unicam) Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 01/11] media: v4l: Add V4L2-PIX-FMT-Y12P format Jean-Michel Hautbois
2022-02-02 21:06 ` Laurent Pinchart [this message]
2022-02-02 17:56 ` [RFC PATCH v3 02/11] media: v4l: Add V4L2-PIX-FMT-Y14P format Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 03/11] media: dt-bindings: media: Add bindings for bcm2835-unicam Jean-Michel Hautbois
2022-02-02 18:33 ` Stefan Wahren
2022-02-02 22:09 ` Jean-Michel Hautbois
2022-02-02 22:35 ` Laurent Pinchart
2022-02-03 11:36 ` Dave Stevenson
2022-02-02 17:56 ` [RFC PATCH v3 04/11] media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 05/11] ARM: dts: bcm2711: Add unicam CSI nodes Jean-Michel Hautbois
2022-02-02 18:24 ` Stefan Wahren
2022-02-02 17:56 ` [RFC PATCH v3 06/11] media: imx219: Rename mbus codes array Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 07/11] media: imx219: Switch from open to init_cfg Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 08/11] media: imx219: Introduce the set_routing operation Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 09/11] media: imx219: use a local v4l2_subdev to simplify reading Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 10/11] media: imx219: Add support for the V4L2 subdev active state Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 11/11] media: bcm283x: Include the imx219 node Jean-Michel Hautbois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfryOKmX+Qc6WYce@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=jeanmichel.hautbois@ideasonboard.com \
--cc=kernel-list@raspberrypi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lukasz@jany.st \
--cc=mchehab@kernel.org \
--cc=naush@raspberrypi.com \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®