From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD425C433EF for ; Wed, 2 Feb 2022 23:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348228AbiBBX7t (ORCPT ); Wed, 2 Feb 2022 18:59:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233189AbiBBX7r (ORCPT ); Wed, 2 Feb 2022 18:59:47 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F370C061714; Wed, 2 Feb 2022 15:59:47 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 283D349C; Thu, 3 Feb 2022 00:59:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1643846384; bh=Y2/calNJ4NZSqNPD6NtTHVhrK+72wYv7CuqinZ68NdY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GT0UYMc+JVzQ6sWGsqVFdLiNOUyhbB0wvhIONT0mHlBjpH8uBlgXJ7avcd33xaddb wtgOmrZ0hBrOwd6gfOvX3KQPONaKJgHwf/cYUAYWa94naB4Ckxvdl4n+3t2sF+SX7z jvLnIcZGY4poCz9zqBMxGNj6XWuBQUsI+EIW7+4A= Date: Thu, 3 Feb 2022 01:59:20 +0200 From: Laurent Pinchart To: Aditya Garg Cc: "mchehab@kernel.org" , "mchehab+huawei@kernel.org" , "hverkuil@xs4all.nl" , "sergey.senozhatsky@gmail.com" , "ribalda@chromium.org" , Linux Kernel Mailing List , "linux-media@vger.kernel.org" , Orlando Chamberlain , "paul@mrarm.io" , Aun-Ali Zaidi Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera Message-ID: References: <527C2E71-12E2-45D1-9B50-5A413B6920A1@live.com> <951C1FB9-9709-4CB3-8DD7-703900FE56FD@live.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <951C1FB9-9709-4CB3-8DD7-703900FE56FD@live.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Aditya, On Wed, Feb 02, 2022 at 07:08:21AM +0000, Aditya Garg wrote: > > On 02-Feb-2022, at 12:07 PM, Laurent Pinchart wrote: > > On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote: > >> From: Paul Pawlowski > >> > >> Adds the requisite device id to support detection of the Apple FaceTime > >> HD webcam exposed over the T2 BCE VHCI interface. > >> > >> Tested-by: Aun-Ali Zaidi > >> Signed-off-by: Paul Pawlowski > >> Signed-off-by: Aun-Ali Zaidi > >> Signed-off-by: Aditya Garg > >> --- > >> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > >> index 7c007426e..88dc9e7aa 100644 > >> --- a/drivers/media/usb/uvc/uvc_driver.c > >> +++ b/drivers/media/usb/uvc/uvc_driver.c > >> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = { > >> .bInterfaceProtocol = 0, > >> .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX > >> | UVC_QUIRK_BUILTIN_ISIGHT) }, > >> + /* Apple FaceTime HD Camera (Built-In) */ > >> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > >> + | USB_DEVICE_ID_MATCH_INT_INFO, > >> + .idVendor = 0x05ac, > >> + .idProduct = 0x8514, > >> + .bInterfaceClass = USB_CLASS_VIDEO, > >> + .bInterfaceSubClass = 1, > >> + .bInterfaceProtocol = 0, > >> + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def }, > > > > Have you tested that the device doesn't work without this quirk ? > > uvcvideo 1-2:1.1: Failed to query (129) UVC probe control : -110 (exp. 48). > uvcvideo 1-2:1.1: Failed to initialize the device (-5). > > These errors are encountered without this patch Thank you for the confirmation. Reviewed-by: Laurent Pinchart and applied to my tree. > >> /* Apple Built-In iSight via iBridge */ > >> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > >> | USB_DEVICE_ID_MATCH_INT_INFO, -- Regards, Laurent Pinchart