mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	tangmeng <tangmeng@uniontech.com>,
	keescook@chromium.org, yzaikin@google.com,
	john.stultz@linaro.org, sboyd@kernel.org,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v5] kernel/time: move timer sysctls to its own file
Date: Thu, 3 Feb 2022 11:53:31 -0800	[thread overview]
Message-ID: <Yfwyu0N4+f51J9OU@bombadil.infradead.org> (raw)
In-Reply-To: <87r18ks379.ffs@tglx>

On Thu, Feb 03, 2022 at 10:35:06AM +0100, Thomas Gleixner wrote:
> On Wed, Feb 02 2022 at 17:17, Luis Chamberlain wrote:
> > On Thu, Feb 03, 2022 at 01:21:46AM +0100, Thomas Gleixner wrote:
> > *Today* all filesystem syctls now get reviewed by fs folks. They are
> > all tidied up there.
> >
> > In the future x86 folks can review their sysctls. But for no reason
> > should I have to review every single knob. That's not scalable.
> 
> Fair enough, but can we please have a changelog which explains the
> rationale to the people who have not been part of that discussion and
> decision.

Sure thing, tangmeng please update the commit log a bit better.

> >> That aside, I'm tired of this because this is now at V5 and you still
> >> failed to fix the fallout reported by the 0-day infrastructure vs. this
> >> part of the patch:
> >> 
> >> > +static int __init timer_sysctl_init(void)
> >> > +{
> >> > +	register_sysctl_init("kernel", timer_sysctl);
> >> > +	return 0;
> >> > +}
> >> 
> >>     kernel/time/timer.c: In function 'timer_sysctl_init':
> >>  >> kernel/time/timer.c:284:9: error: implicit declaration of function 'register_sysctl_init'; did you mean 'timer_sysctl_init'? [-Werror=implicit-function-declaration]
> >>       284 |         register_sysctl_init("kernel", timer_sysctl);
> >> 	  |         ^~~~~~~~~~~~~~~~~~~~
> >> 
> >
> > That's an issue with the patch being tested on a tree where that
> > routine is not present?
> 
> From the report:
> 
>   ...
>   [also build test ERROR on linus/master
> 
> Linus tree has this interface. So that's not the problem.
> 
> Hint #1: The interfaxce is not available unconditionally
> 
> Hint #2: The 0-day reports provide the config file which exposes the
>          fail

tangmeng, please fix.

  Luis

      reply	other threads:[~2022-02-03 19:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 10:22 tangmeng
2022-02-01 12:24 ` kernel test robot
2022-02-01 12:54 ` kernel test robot
2022-02-01 18:59 ` Luis Chamberlain
2022-02-03  0:21 ` Thomas Gleixner
2022-02-03  1:17   ` Luis Chamberlain
2022-02-03  9:35     ` Thomas Gleixner
2022-02-03 19:53       ` Luis Chamberlain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yfwyu0N4+f51J9OU@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=keescook@chromium.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tangmeng@uniontech.com \
    --cc=tglx@linutronix.de \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®