From: "Luck, Tony" <tony.luck@intel.com>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc: x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [RFC PATCH 1/2] x86/mce: Handle AMD threshold interrupt storms
Date: Thu, 17 Feb 2022 09:28:09 -0800 [thread overview]
Message-ID: <Yg6FqR2cMZDwdBdi@agluck-desk3.sc.intel.com> (raw)
In-Reply-To: <20220217141609.119453-2-Smita.KoralahalliChannabasappa@amd.com>
On Thu, Feb 17, 2022 at 08:16:08AM -0600, Smita Koralahalli wrote:
> Extend the logic of handling CMCI storms to AMD threshold interrupts.
>
> Similar to CMCI storm handling, keep track of the rate at which each
> processor sees interrupts. If it exceeds threshold, disable interrupts
> and switch to polling of machine check banks.
I've been sitting on some partially done patches to re-work
storm handling for Intel ... which rips out all the existing
storm bits and replaces with something all new. I'll post the
2-part series as replies to this.
Two-part motivation:
1) Disabling CMCI globally is an overly big hammer (as you note
in your patches which to a more gentle per-CPU disable.
2) Intel signals some UNCORRECTED errors using CMCI (yes, turns
out that was a poorly chosen name given the later evolution of
the architecture). Since we don't want to miss those, the proposed
storm code just bumps the threshold to (almost) maximum to mitigate,
but not eliminate the storm. Note that the threshold only applies
to corrected errors.
-Tony
next prev parent reply other threads:[~2022-02-17 17:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 14:16 [RFC PATCH 0/2] " Smita Koralahalli
2022-02-17 14:16 ` [RFC PATCH 1/2] x86/mce: " Smita Koralahalli
2022-02-17 17:28 ` Luck, Tony [this message]
2022-02-17 17:35 ` [PATCH 1/2] x86/mce: Remove old CMCI storm mitigation code Luck, Tony
2022-02-24 15:14 ` Borislav Petkov
2022-02-17 17:36 ` [PATCH 2/2] x86/mce: Add per-bank CMCI storm mitigation Luck, Tony
2022-02-23 22:11 ` Koralahalli Channabasappa, Smita
2022-03-07 13:31 ` Borislav Petkov
2022-03-07 20:04 ` Luck, Tony
2022-02-18 11:07 ` [RFC PATCH 1/2] x86/mce: Handle AMD threshold interrupt storms Borislav Petkov
2022-02-23 22:22 ` Koralahalli Channabasappa, Smita
2022-02-23 23:03 ` Luck, Tony
2022-03-15 18:15 ` [PATCH v2 0/2] New CMCI storm mitigation for Intel CPUs Tony Luck
2022-03-15 18:15 ` [PATCH v2 1/2] x86/mce: Remove old CMCI storm mitigation code Tony Luck
2022-03-15 18:15 ` [PATCH v2 2/2] x86/mce: Add per-bank CMCI storm mitigation Tony Luck
2022-03-15 18:34 ` [PATCH v2 0/2] New CMCI storm mitigation for Intel CPUs Borislav Petkov
2022-03-15 21:46 ` Koralahalli Channabasappa, Smita
2022-02-17 14:16 ` [RFC PATCH 2/2] x86/mce: Simplify code in log_and_reset_block() Smita Koralahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg6FqR2cMZDwdBdi@agluck-desk3.sc.intel.com \
--to=tony.luck@intel.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®