From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B79C4332F for ; Fri, 18 Feb 2022 00:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230085AbiBRAR3 (ORCPT ); Thu, 17 Feb 2022 19:17:29 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:48460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230051AbiBRAR1 (ORCPT ); Thu, 17 Feb 2022 19:17:27 -0500 Received: from thorn.bewilderbeest.net (thorn.bewilderbeest.net [IPv6:2605:2700:0:5::4713:9cab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A0F92DD5A; Thu, 17 Feb 2022 16:17:12 -0800 (PST) Received: from hatter.bewilderbeest.net (174-21-187-98.tukw.qwest.net [174.21.187.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: zev) by thorn.bewilderbeest.net (Postfix) with ESMTPSA id 983A832C; Thu, 17 Feb 2022 16:17:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bewilderbeest.net; s=thorn; t=1645143431; bh=Z7wZg8Re/Dy73Zm8lE3R37EB8e+695AOYuDc/5NXQ5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C4y25U5k2fYvV8ABQkDiU+HBD3JQkGXZOv6A7+8tkzevNYob5hUZOCW9fIUZcYe3I O0A9JqTqKyTbdAgyQ4JJGojEUMeeIRoqvdOtyQ10/yf/3tPSyMMRBmEmElNp1FIzay He+e71Js0bs95/9/VLUgn6N8A+EqaY0E+JYdWczk= Date: Thu, 17 Feb 2022 16:17:08 -0800 From: Zev Weiss To: Rob Herring Cc: devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Guenter Roeck , Jean Delvare , Arnd Bergmann , linux-hwmon@vger.kernel.org, Mark Brown , Liam Girdwood Subject: Re: [PATCH 3/4] dt-bindings: Add power-efuse binding Message-ID: References: <20220217104444.7695-1-zev@bewilderbeest.net> <20220217104444.7695-4-zev@bewilderbeest.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 17, 2022 at 02:35:12PM PST, Rob Herring wrote: >On Thu, Feb 17, 2022 at 02:44:43AM -0800, Zev Weiss wrote: >> This can be used to describe a power output supplied by a regulator >> device that the system controls. >> >> Signed-off-by: Zev Weiss >> --- >> .../devicetree/bindings/misc/power-efuse.yaml | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/misc/power-efuse.yaml >> >> diff --git a/Documentation/devicetree/bindings/misc/power-efuse.yaml b/Documentation/devicetree/bindings/misc/power-efuse.yaml >> new file mode 100644 >> index 000000000000..cadce15d2ce7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/misc/power-efuse.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/misc/power-efuse.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Generic power efuse device > >No idea what this is, but I doubt any such generic device exists. This >needs sufficient description to be convincing that it is indeed generic. > I was struggling a bit to come up with a reasonably concise title; this admittedly isn't great. Would a description like the following clarify it adequately? description: | This binding describes a physical power output supplied by a regulator providing efuse functionality (manual on/off control, and auto-shutoff if current, voltage, or thermal limits are exceeded). These may be found on systems such as "smart" network PDUs, and typically supply power to devices entirely separate from the system described by the device-tree by way of an external connector such as an Open19 power cable: https://www.open19.org/marketplace/coolpower-cable-assembly-8ru/ >> + >> +maintainers: >> + - Zev Weiss >> + >> +properties: >> + compatible: >> + const: power-efuse >> + >> + vout-supply: >> + description: >> + phandle to the regulator providing power for the efuse >> + >> + error-flags-cache-ttl-ms: >> + description: >> + The number of milliseconds the vout-supply regulator's error >> + flags should be cached before re-fetching them. > >What are 'error flags'? Not something I've heard with respect to >regulators. > That refers to the REGULATOR_ERROR_* flags in include/linux/regulator/consumer.h, in whatever "physical" form those ultimately take -- for example, in the PMBus-based case I'm currently aiming to support, they'd map to the flags returned by PMBus STATUS_* commands. Thanks for the review, Zev