From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B44F0C433F5
	for <linux-kernel@archiver.kernel.org>; Tue,  8 Feb 2022 02:28:28 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1345913AbiBHC20 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 7 Feb 2022 21:28:26 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58118 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S237161AbiBHC2W (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 7 Feb 2022 21:28:22 -0500
X-Greylist: delayed 1672 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 07 Feb 2022 18:28:20 PST
Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA6BCC061355;
        Mon,  7 Feb 2022 18:28:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=JMHymrZvU08T3r4BdtgDATv2Fh8Jo5X8RbDz8bhcHfM=; b=PD1RoF42O49tywgxC//b8v0Bbb
        5VYGVygkbqH0eSUMoGyii6i/7Lm6bX7BC5lRZkcSUw1o6LDiyd2rOyOHOIMuozL5ASp+OY5x+kT4H
        2DwRaaWzjSHb7qHU3yN9UOVFGvKYeL6CGo+eqjY/gmvhKRPVr4RojS6bTJ3D9IwjsFI8=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1nHFnu-004jlK-0o; Tue, 08 Feb 2022 03:00:26 +0100
Date:   Tue, 8 Feb 2022 03:00:26 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Pawel Dembicki <paweldembicki@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: Add Ctera C-200 V1 board
Message-ID: <YgHOup5cKZJyxWFB@lunn.ch>
References: <20220207212014.28551-1-paweldembicki@gmail.com>
 <20220207212014.28551-2-paweldembicki@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220207212014.28551-2-paweldembicki@gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 07, 2022 at 10:20:14PM +0100, Pawel Dembicki wrote:
> Ctera C200 V1 is kirkwood-based 2-Bay NAS.
> 
> Hardware:
>   - SoC: Marvell 88F6281-A1 ARMv5TE Processor 1.2GHz
>   - Ram: 512MB (4x Nanya NT5TU128M8GE-AC)
>   - NAND Flash: 256MB (Samsung 216 K9F2G08U0C)
>   - Lan: 1x GBE (Marvell 88E1116R-NNC1)
>   - Storage: 2x SATA HDD 3.5" Slot
>   - USB: 2x USB 2.0 port
>   - Console: Internal J3 connector (1: Vcc, 2: Rx, 3: Tx, 4: GND)
>   - LEDs: 13x GPIO controlled
>   - Buttons: 2x GPIO controlled
> 
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>

Hi Pawel

It is a good idea to Cc: the mvebu maintainers, since kirkwood is part
of that.

> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-0 = <&pmx_leds>;
> +		pinctrl-names = "default";
> +
> +

Please avoid 2 blank lines. This happens a few times in this file.

> +&pciec {
> +	status = "okay";
> +};

It would be nice to have a comment about what is on the PCIe bus. Or
is it just a socket?

> +
> +&pcie0 {
> +	status = "okay";
> +};
> +
> +&pinctrl {
> +	/* buzzer gpios are connected to two pins of buzzer
> +	 * leave it as is due lack of proper driver
> +	 */
> +	pmx_buzzer: pmx-buzzer {
> +		marvell,pins = "mpp12", "mpp13";
> +		marvell,function = "gpio";
> +	};

Is it possible to use "gpio-beeper"?

        beeper: beeper {
                /* 4KHz Piezoelectric buzzer */
                compatible = "gpio-beeper";
                pinctrl-0 = <&pmx_beeper>;
                pinctrl-names = "default";
                gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
        };

	Andrew