mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	Michael Straube <straube.linux@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] staging: r8188eu: remove ishighspeed from dvobj_priv
Date: Tue, 8 Feb 2022 10:30:31 +0100	[thread overview]
Message-ID: <YgI4N1X18cr9QApA@kroah.com> (raw)
In-Reply-To: <20220206175925.461426-6-martin@kaiser.cx>

On Sun, Feb 06, 2022 at 06:59:25PM +0100, Martin Kaiser wrote:
> There's no need to store the usb device speed in struct dvobj_priv.
> 
> We can read the speed from struct usb_device. dvobj_priv has a pointer
> to the usb_device.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  drivers/staging/r8188eu/core/rtw_iol.c      | 4 +++-
>  drivers/staging/r8188eu/hal/usb_halinit.c   | 4 ++--
>  drivers/staging/r8188eu/include/drv_types.h | 1 -
>  drivers/staging/r8188eu/include/usb_ops.h   | 2 +-
>  drivers/staging/r8188eu/os_dep/usb_intf.c   | 8 --------
>  5 files changed, 6 insertions(+), 13 deletions(-)

This commit did not apply probably due to other changes to the driver at
the same time by other patch series.  Can you rebase it and resend?  The
other 4 were fine and now in my tree.

thanks,

greg k-h

      reply	other threads:[~2022-02-08  9:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-06 17:59 [PATCH 0/5] staging: r8188eu: clean up struct dvobj_priv Martin Kaiser
2022-02-06 17:59 ` [PATCH 1/5] staging: r8188eu: usb_vendor_req_mutex is not used Martin Kaiser
2022-02-06 17:59 ` [PATCH 2/5] staging: r8188eu: dvobj_priv's signal_strength " Martin Kaiser
2022-02-06 17:59 ` [PATCH 3/5] staging: r8188eu: RegUsbSS " Martin Kaiser
2022-02-06 17:59 ` [PATCH 4/5] staging: r8188eu: usb_suspend_sema is initialised but " Martin Kaiser
2022-02-06 17:59 ` [PATCH 5/5] staging: r8188eu: remove ishighspeed from dvobj_priv Martin Kaiser
2022-02-08  9:30   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgI4N1X18cr9QApA@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®