From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0E6C433EF for ; Wed, 9 Feb 2022 13:56:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234605AbiBIN4k (ORCPT ); Wed, 9 Feb 2022 08:56:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234583AbiBIN4h (ORCPT ); Wed, 9 Feb 2022 08:56:37 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C76BCC05CB8F for ; Wed, 9 Feb 2022 05:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644415000; x=1675951000; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xBjttyyMrZXC5nplVL/cvGF1ir/hZw4ovvvgsddLC8c=; b=TWzrxNwBItv0MOyW/dxUEuuRpMn79gtnEChEWXoHl17ooT6vlzZTfUT7 L+todNecLU6lpnPXpGBLnjeGhysODDdtO93e+JrWjE/u2U6ga6iiVl8No e0y1c3Dw7SmTpIQEF5UQ+yOItVjKDZZrZAcrXBgTZ+NsIuy/fnqwqoLqq ItbyVqwiIPOIZpsKRuGQJTduI3u39CO2T5iKfSg9aXwtJmVc1iWtNu04z m28qQBEjVJ0Km+XJ3T/mdJby+r/hhKTzCKP8lb4Xfopd0e2gVg5dqWRYT pFJ1I1evpph+mDxRR+sAzC9lZcHnZqASgA7kmzdT4dfx3e56YcNs4FKrm g==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="248967106" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="248967106" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 05:56:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="678596354" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 09 Feb 2022 05:56:36 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 09 Feb 2022 15:56:36 +0200 Date: Wed, 9 Feb 2022 15:56:36 +0200 From: Heikki Krogerus To: Pavel Skripkin Cc: syzbot , andriy.shevchenko@linux.intel.com, dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com, rafael@kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] WARNING in component_del Message-ID: References: <00000000000016f4ae05d5cec832@google.com> <000000000000a17f2305d77f4cb7@google.com> <250ce1c2-95bf-3067-7bd6-5655038c5e69@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <250ce1c2-95bf-3067-7bd6-5655038c5e69@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 09, 2022 at 04:51:44PM +0300, Pavel Skripkin wrote: > Hi Heikki, > > On 2/9/22 16:42, Heikki Krogerus wrote: > > On Tue, Feb 08, 2022 at 02:37:10AM -0800, syzbot wrote: > > > syzbot has bisected this issue to: > > > > > > commit 8c67d06f3fd9639c44d8147483fb1c132d71388f > > > Author: Heikki Krogerus > > > Date: Thu Dec 23 08:23:49 2021 +0000 > > > > > > usb: Link the ports to the connectors they are attached to > > > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14063168700000 > > > start commit: 555f3d7be91a Merge tag '5.17-rc3-ksmbd-server-fixes' of gi.. > > > git tree: upstream > > > final oops: https://syzkaller.appspot.com/x/report.txt?x=16063168700000 > > > console output: https://syzkaller.appspot.com/x/log.txt?x=12063168700000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=266de9da75c71a45 > > > dashboard link: https://syzkaller.appspot.com/bug?extid=60df062e1c41940cae0f > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15880d84700000 > > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14de0c77b00000 > > > > > > Reported-by: syzbot+60df062e1c41940cae0f@syzkaller.appspotmail.com > > > Fixes: 8c67d06f3fd9 ("usb: Link the ports to the connectors they are attached to") > > > > > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection > > > > I'm guessing the component_add() is failing in this case. So I guess > > we need to consider the component_add() failures fatal in > > drivers/usb/core/port.c, which is a bit of a bummer. I'll send the > > fix. > > > > Seems something similar to your approach is already posted > > https://lore.kernel.org/linux-usb/20220208170048.24718-1-fmdefrancesco@gmail.com/ Ah, thanks! That one seems to leave the peer links, so it's broken... Br, -- heikki