From: Catalin Marinas <catalin.marinas@arm.com>
To: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
Cc: Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Marc Zyngier <maz@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
gregkh <gregkh@linuxfoundation.org>,
quic_psodagud@quicinc.com, Trilok Soni <quic_tsoni@quicinc.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCHv9 1/5] arm64: io: Use asm-generic high level MMIO accessors
Date: Wed, 9 Feb 2022 18:52:57 +0000 [thread overview]
Message-ID: <YgQNiXsh4hC+5+O5@arm.com> (raw)
In-Reply-To: <87926437f2f9e72dd94f0b30c8784c2da5508644.1642482334.git.quic_saipraka@quicinc.com>
On Mon, Jan 24, 2022 at 12:03:30PM +0530, Sai Prakash Ranjan wrote:
> Remove custom arm64 MMIO accessors read{b,w,l,q} and their relaxed
> versions in support to use asm-generic defined accessors. Also define
> one set of IO barriers (ar/bw version) used by asm-generic code to
> override the arm64 specific variants.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
I'm fine with this patch:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> index 7fd836bea7eb..1b436810d779 100644
> --- a/arch/arm64/include/asm/io.h
> +++ b/arch/arm64/include/asm/io.h
[...]
> +/* arm64-specific, don't use in portable drivers */
> +#define __iormb(v) __io_ar(v)
> +#define __iowmb() __io_bw()
> +#define __iomb() dma_mb()
However, I'd like to see a few subsequent patches that get rid of the
__io*mb() uses in drivers/ (there don't seem to be that many).
--
Catalin
next prev parent reply other threads:[~2022-02-09 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 6:33 [PATCHv9 0/5] lib/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan
2022-01-24 6:33 ` [PATCHv9 1/5] arm64: io: Use asm-generic high level MMIO accessors Sai Prakash Ranjan
2022-02-09 18:52 ` Catalin Marinas [this message]
2022-02-10 7:36 ` Sai Prakash Ranjan
2022-01-24 6:33 ` [PATCHv9 2/5] irqchip/tegra: Fix overflow implicit truncation warnings Sai Prakash Ranjan
[not found] ` <8735lc88n9.wl-maz@kernel.org>
2022-01-25 13:35 ` Sai Prakash Ranjan
2022-01-24 6:33 ` [PATCHv9 3/5] drm/meson: " Sai Prakash Ranjan
2022-01-24 6:33 ` [PATCHv9 4/5] lib: Add register read/write tracing support Sai Prakash Ranjan
2022-02-14 3:37 ` Sai Prakash Ranjan
2022-01-24 6:33 ` [PATCHv9 5/5] asm-generic/io: Add logging support for MMIO accessors Sai Prakash Ranjan
2022-02-14 3:40 ` Sai Prakash Ranjan
2022-01-31 18:56 ` [PATCHv9 0/5] lib/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan
2022-02-08 9:31 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgQNiXsh4hC+5+O5@arm.com \
--to=catalin.marinas@arm.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=quic_psodagud@quicinc.com \
--cc=quic_saipraka@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®