mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH 2/2] random: deobfuscate irq u32/u64 contributions
Date: Thu, 10 Feb 2022 17:55:53 +0100	[thread overview]
Message-ID: <YgVDmcG78PVoP4U3@owl.dominikbrodowski.net> (raw)
In-Reply-To: <20220210160925.156697-3-Jason@zx2c4.com>

Am Thu, Feb 10, 2022 at 05:09:25PM +0100 schrieb Jason A. Donenfeld:
> In the irq handler, we fill out 16 bytes differently on 32-bit and
> 64-bit platforms. Whether or not you like that, it is a matter of fact.
> But it might not be a fact you well realized until now, because the code
> that loaded the irq info into 4 32-bit words was quite confusing.
> Instead, this commit makes everything explicit by having separate
> (compile-time) branches for 32-bit and 64-bit machines. In the process,
> it exposed a shortcoming in in mix_interrupt_randomness() which we

"in in" -> "in"

> rectify.

Maybe explain the shortcoming in one sentence? I think I spotted it, but...

Thanks,
	Dominik

  reply	other threads:[~2022-02-10 16:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 16:09 [PATCH 0/2] random: make irq collector clearer Jason A. Donenfeld
2022-02-10 16:09 ` [PATCH 1/2] random: move fast_pool/fast_mix definitions to site of use Jason A. Donenfeld
2022-02-10 16:46   ` Dominik Brodowski
2022-02-10 16:09 ` [PATCH 2/2] random: deobfuscate irq u32/u64 contributions Jason A. Donenfeld
2022-02-10 16:55   ` Dominik Brodowski [this message]
2022-02-10 17:10     ` Jason A. Donenfeld
2022-02-10 17:13       ` [PATCH v2] " Jason A. Donenfeld
2022-02-11  5:57         ` Dominik Brodowski
2022-02-15 11:48           ` [PATCH v3] " Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgVDmcG78PVoP4U3@owl.dominikbrodowski.net \
    --to=linux@dominikbrodowski.net \
    --cc=Jason@zx2c4.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®