From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAB65C433F5 for ; Sun, 13 Feb 2022 06:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233489AbiBMG5T (ORCPT ); Sun, 13 Feb 2022 01:57:19 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234002AbiBMG5H (ORCPT ); Sun, 13 Feb 2022 01:57:07 -0500 Received: from isilmar-4.linta.de (isilmar-4.linta.de [136.243.71.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6336D5DE68 for ; Sat, 12 Feb 2022 22:57:02 -0800 (PST) X-isilmar-external: YES X-isilmar-external: YES Received: from owl.dominikbrodowski.net (owl.brodo.linta [10.2.0.111]) by isilmar-4.linta.de (Postfix) with ESMTPSA id DF8A2201407; Sun, 13 Feb 2022 06:56:59 +0000 (UTC) Received: by owl.dominikbrodowski.net (Postfix, from userid 1000) id E09C680A0E; Sun, 13 Feb 2022 07:55:12 +0100 (CET) Date: Sun, 13 Feb 2022 07:55:12 +0100 From: Dominik Brodowski To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] random: do not take pool spinlock at boot Message-ID: References: <20220212002859.622233-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220212002859.622233-1-Jason@zx2c4.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sat, Feb 12, 2022 at 01:28:59AM +0100 schrieb Jason A. Donenfeld: > Since rand_initialize() is run while interrupts are still off and > nothing else is running, we don't need to repeatedly take and release > the pool spinlock, especially in the RDSEED loop. > > Cc: Dominik Brodowski > Signed-off-by: Jason A. Donenfeld > --- > Dominik - I'm still a bit unclear about early boot semantics that you > seem to know well. Is this patch correct? It seems to be. Reviewed-by: Dominik Brodowski Thanks, Dominik