mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [willy-pagecache:for-next 58/85] mm/folio-compat.c:181:9: error: implicit declaration of function 'folio_mlock'; did you mean 'folio_lock'?
Date: Mon, 14 Feb 2022 17:28:34 +0000	[thread overview]
Message-ID: <YgqRQtFh0qnenzJg@casper.infradead.org> (raw)
In-Reply-To: <202202142352.7A4VgqBz-lkp@intel.com>

On Tue, Feb 15, 2022 at 01:19:26AM +0800, kernel test robot wrote:
> commit: 2cefeaf011db4a95ecb515cc2ca61d091a792ac1 [58/85] mm/rmap: Turn page_mlock() into folio_mlock()
> 
>    mm/folio-compat.c:169:6: warning: no previous prototype for 'clear_page_mlock' [-Wmissing-prototypes]
>      169 | void clear_page_mlock(struct page *page)
>          |      ^~~~~~~~~~~~~~~~
>    mm/folio-compat.c:174:6: error: redefinition of 'mlock_vma_page'
>      174 | void mlock_vma_page(struct page *page)
>          |      ^~~~~~~~~~~~~~
>    In file included from mm/folio-compat.c:11:
>    mm/internal.h:503:20: note: previous definition of 'mlock_vma_page' with type 'void(struct page *)'
>      503 | static inline void mlock_vma_page(struct page *page) { }
>          |                    ^~~~~~~~~~~~~~
>    mm/folio-compat.c: In function 'mlock_vma_page':
>    mm/folio-compat.c:176:9: error: implicit declaration of function 'mlock_vma_folio'; did you mean 'mlock_vma_page'? [-Werror=implicit-function-declaration]
>      176 |         mlock_vma_folio(page_folio(page));
>          |         ^~~~~~~~~~~~~~~
>          |         mlock_vma_page
>    mm/folio-compat.c: At top level:
>    mm/folio-compat.c:179:6: warning: no previous prototype for 'page_mlock' [-Wmissing-prototypes]
>      179 | void page_mlock(struct page *page)
>          |      ^~~~~~~~~~
>    mm/folio-compat.c: In function 'page_mlock':
> >> mm/folio-compat.c:181:9: error: implicit declaration of function 'folio_mlock'; did you mean 'folio_lock'? [-Werror=implicit-function-declaration]
>      181 |         folio_mlock(page_folio(page));
>          |         ^~~~~~~~~~~
>          |         folio_lock
>    cc1: some warnings being treated as errors

All fixed in an update I pushed about two hours ago ;-)

      reply	other threads:[~2022-02-14 17:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-14 17:19 kernel test robot
2022-02-14 17:28 ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgqRQtFh0qnenzJg@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®