From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Xin Ji <xji@analogixsemi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
bliang@analogixsemi.com, qwen@analogixsemi.com,
jli@analogixsemi.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support
Date: Tue, 15 Feb 2022 14:43:17 +0200 [thread overview]
Message-ID: <Yguf5bwRkqolW0+/@kuha.fi.intel.com> (raw)
In-Reply-To: <20220215054300.GA3752727@anxtwsw-Precision-3640-Tower>
On Tue, Feb 15, 2022 at 01:43:00PM +0800, Xin Ji wrote:
> On Wed, Feb 09, 2022 at 03:31:26PM +0200, Heikki Krogerus wrote:
> > On Tue, Feb 08, 2022 at 05:16:21PM +0800, Xin Ji wrote:
> > > Add driver for analogix ANX7411 USB Type-C DRP port controller.
> >
> > We already have the driver drivers/usb/typec/tcpm/tcpci.c for port
> > controllers.
> >
> > If you need a glue layer - if there is something specific that you
> > need to do with ANX7411 that is not completely TCPC compliant - use
> > drivers/usb/typec/tcpm/tcpci_*.c as examples.
> Hi heikki, ANX7411 PD controller has 2 applications, the one has embeded
> internal firmware, the other is not have. The currently upstream patch
> is for the first way, driver mustn't use TCPCI framework(embeded firmware
> will control all the TCPCI register). The second way(erased internaly
> firmware) can work under TCPCI framework.
Ah, so it has a microcontroller. Fair enough. I'll take another
look at your patch.
thanks,
--
heikki
next prev parent reply other threads:[~2022-02-15 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 9:16 [PATCH v5 1/2] dt-bindings: usb: Add analogix anx7411 PD binding Xin Ji
2022-02-08 9:16 ` [PATCH v5 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support Xin Ji
2022-02-09 13:31 ` Heikki Krogerus
2022-02-15 5:43 ` Xin Ji
2022-02-15 12:43 ` Heikki Krogerus [this message]
2022-02-15 15:41 ` Heikki Krogerus
2022-02-21 12:07 ` Xin Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yguf5bwRkqolW0+/@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=bliang@analogixsemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=jli@analogixsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=qwen@analogixsemi.com \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®