From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4646C433EF for ; Tue, 15 Feb 2022 22:57:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244718AbiBOW5Y (ORCPT ); Tue, 15 Feb 2022 17:57:24 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244711AbiBOW5T (ORCPT ); Tue, 15 Feb 2022 17:57:19 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E130D4CBA for ; Tue, 15 Feb 2022 14:56:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lxDxiH7YdaguzLVLUSqqsB5d4iEpIHEpukWCHc1REm0=; b=EelEfSfmJZSj7jPR8xdrytLvOv vvUegttSQBNXTCISxTbXxPrmJ3ijUCphVHjWXzE5fzvUSjXjgspgCUuw/AooGJM3x20gIF2JvPJCV Gr7jF/6+VPXHTn5p6oQYvOOdahT4NrKPvmxVpYH9NobncBN9rut7BziYG9r9sb8oOrGxy9XBaXXIw lopSMV62eX5PhZgVOKfGsWjasY9ZBEuxFoA9uyQ5zoLd3Yw2uPBDcikP8sjKIweQuXrki7JmYHalt vJCwUxPIlS2v6dDqrKb0d4JKpxhOoVKrCGPHuRudPQBuWKe6sTGs3YVuOVr8AS7BIFdxRsIWKQdW/ hq8pA/JQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK6kL-00EEoo-QD; Tue, 15 Feb 2022 22:56:33 +0000 Date: Tue, 15 Feb 2022 22:56:33 +0000 From: Matthew Wilcox To: Hugh Dickins Cc: Andrew Morton , Michal Hocko , Vlastimil Babka , "Kirill A. Shutemov" , David Hildenbrand , Alistair Popple , Johannes Weiner , Rik van Riel , Suren Baghdasaryan , Yu Zhao , Greg Thelen , Shakeel Butt , Yang Li , SeongJae Park , Geert Uytterhoeven , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 10/13] mm/munlock: mlock_page() munlock_page() batch by pagevec Message-ID: References: <55a49083-37f9-3766-1de9-9feea7428ac@google.com> <1abb94ee-fe72-dba9-3eb0-d1e576d148e6@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 15, 2022 at 01:02:30PM -0800, Hugh Dickins wrote: > On Tue, 15 Feb 2022, Matthew Wilcox wrote: > > > +#define mlock_new(page) ((struct page *)((unsigned long)page + NEW_PAGE)) > > > > I'm going to change this to: > > > > static inline struct page *mlock_lru(struct page *page) > > { > > return (struct page *)((unsigned long)page + LRU_PAGE); > > } > > > > (mutatis mutandi for mlock_new) > > Okay, thanks. (You're not naming your folio "page" :-?) Worse, I tried passing it '&folio->page'. That produced some ... interesting compiler error messages.