mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Nicolai Stange <nstange@suse.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Stephan Müller" <smueller@chronox.de>,
	"Hannes Reinecke" <hare@suse.de>, "Torsten Duwe" <duwe@suse.de>,
	"David Howells" <dhowells@redhat.com>,
	"Jarkko Sakkinen" <jarkko@kernel.org>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	keyrings@vger.kernel.org
Subject: Re: [PATCH v4 00/15] crypto: dh - infrastructure for NVM in-band auth and FIPS conformance
Date: Thu, 3 Mar 2022 10:58:36 +1200	[thread overview]
Message-ID: <Yh/2nD1wEh0BovMC@gondor.apana.org.au> (raw)
In-Reply-To: <20220221121101.1615-1-nstange@suse.de>

On Mon, Feb 21, 2022 at 01:10:46PM +0100, Nicolai Stange wrote:
> Hi all,
> 
> first of all, to the people primarily interested in security/keys/, there's
> a rather trivial change to security/keys/dh.c in patch 4/15. It would be
> great to get ACKs for that...
> 
> This patchset's main objective is to provide the DH related preprequisite
> bits needed by the upcoming support for NVME in-band authentication ([1]),
> namely
> - support for the RFC 7919 ffdheXYZ group parameters (patches [1-8/15]) and
> - an ephemeral key generation primitive for these (patches [9-11/15]).
> 
> With this in place, it happens to become relatively straight-forward to
> achieve conformance with NIST SP800-56Ar3. The remainder of this patchset,
> i.e. patches [12-15/15], implements the required changes.
> 
> The previous v3 of this patchset can be found at [2]. The only difference
> between v3 and the v4 here is the removal of a superfluous "default n"
> Kconfig statement in patch [7/15] ("crypto: dh - implement ffdheXYZ(dh)
> templates").
> 
> I would like to reiterate that [12/15] ("crypto: api - allow algs only in
> specific constructions in FIPS mode") is heavily based on a patch
> previously posted by Herbert. Please refer to the v3 cover letter at [2]
> for the full history.
> 
> Finally note that Stephan has granted his
> Tested-by: Stephan Mueller <smueller@chronox.de>
> to v3 already ([3]). Stephan, with the trivial diff between v3 and v4,
> would you be Ok with carrying it over?
> 
> Thanks,
> 
> Nicolai
> 
> [1] https://lore.kernel.org/r/20211202152358.60116-1-hare@suse.de
> [2] https://lore.kernel.org/r/20220202104012.4193-1-nstange@suse.de
> [3] https://lore.kernel.org/r/8937519.l8FpVtv5Hg@tauon.chronox.de
> 
> Nicolai Stange (15):
>   crypto: kpp - provide support for KPP template instances
>   crypto: kpp - provide support for KPP spawns
>   crypto: dh - remove struct dh's ->q member
>   crypto: dh - constify struct dh's pointer members
>   crypto: dh - split out deserialization code from crypto_dh_decode()
>   crypto: dh - introduce common code for built-in safe-prime group
>     support
>   crypto: dh - implement ffdheXYZ(dh) templates
>   crypto: testmgr - add known answer tests for ffdheXYZ(dh) templates
>   crypto: dh - implement private key generation primitive for
>     ffdheXYZ(dh)
>   crypto: testmgr - add keygen tests for ffdheXYZ(dh) templates
>   crypto: dh - allow for passing NULL to the ffdheXYZ(dh)s'
>     ->set_secret()
>   crypto: api - allow algs only in specific constructions in FIPS mode
>   crypto: dh - disallow plain "dh" usage in FIPS mode
>   lib/mpi: export mpi_rshift
>   crypto: dh - calculate Q from P for the full public key verification
> 
>  crypto/Kconfig                |    7 +
>  crypto/algapi.c               |   18 +-
>  crypto/api.c                  |   19 +-
>  crypto/dh.c                   |  687 +++++++++++++++-
>  crypto/dh_helper.c            |   42 +-
>  crypto/kpp.c                  |   29 +
>  crypto/tcrypt.c               |    4 +-
>  crypto/testmgr.c              |   61 +-
>  crypto/testmgr.h              | 1445 ++++++++++++++++++++++++++++++++-
>  include/crypto/dh.h           |   26 +-
>  include/crypto/internal/kpp.h |  158 ++++
>  include/linux/crypto.h        |    9 +
>  lib/mpi/mpi-bit.c             |    1 +
>  security/keys/dh.c            |    2 +-
>  14 files changed, 2441 insertions(+), 67 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      parent reply	other threads:[~2022-03-03  0:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 12:10 Nicolai Stange
2022-02-21 12:10 ` [PATCH v4 01/15] crypto: kpp - provide support for KPP template instances Nicolai Stange
2022-02-21 13:18   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 02/15] crypto: kpp - provide support for KPP spawns Nicolai Stange
2022-02-21 14:11   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 03/15] crypto: dh - remove struct dh's ->q member Nicolai Stange
2022-02-21 12:10 ` [PATCH v4 04/15] crypto: dh - constify struct dh's pointer members Nicolai Stange
2022-02-21 14:12   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 05/15] crypto: dh - split out deserialization code from crypto_dh_decode() Nicolai Stange
2022-02-21 14:13   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 06/15] crypto: dh - introduce common code for built-in safe-prime group support Nicolai Stange
2022-02-21 14:14   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 07/15] crypto: dh - implement ffdheXYZ(dh) templates Nicolai Stange
2022-02-21 14:15   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 08/15] crypto: testmgr - add known answer tests for " Nicolai Stange
2022-02-21 14:16   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 09/15] crypto: dh - implement private key generation primitive for ffdheXYZ(dh) Nicolai Stange
2022-02-21 14:17   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 10/15] crypto: testmgr - add keygen tests for ffdheXYZ(dh) templates Nicolai Stange
2022-02-21 14:18   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 11/15] crypto: dh - allow for passing NULL to the ffdheXYZ(dh)s' ->set_secret() Nicolai Stange
2022-02-21 14:18   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 12/15] crypto: api - allow algs only in specific constructions in FIPS mode Nicolai Stange
2022-02-21 14:19   ` Hannes Reinecke
2022-02-21 12:10 ` [PATCH v4 13/15] crypto: dh - disallow plain "dh" usage " Nicolai Stange
2022-02-21 14:19   ` Hannes Reinecke
2022-02-21 12:11 ` [PATCH v4 14/15] lib/mpi: export mpi_rshift Nicolai Stange
2022-02-21 12:11 ` [PATCH v4 15/15] crypto: dh - calculate Q from P for the full public key verification Nicolai Stange
2022-02-21 14:20   ` Hannes Reinecke
2022-03-02 22:58 ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yh/2nD1wEh0BovMC@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=duwe@suse.de \
    --cc=hare@suse.de \
    --cc=jarkko@kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nstange@suse.de \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®