From: Borislav Petkov <bp@alien8.de>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: weidonghui <weidonghui@allwinnertech.com>,
tools@linux.kernel.org, linux-kernel@vger.kernel.org,
gwml@vger.gnuweeb.org, x86@kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] scripts/decodecode: Make objdump always use operand-size suffix
Date: Tue, 1 Mar 2022 11:44:31 +0100 [thread overview]
Message-ID: <Yh35BQrhlus2uCca@nazgul.tnic> (raw)
In-Reply-To: <93a60cc2-52df-878e-6b07-dd80d5d3f149@gnuweeb.org>
On Tue, Mar 01, 2022 at 04:16:47PM +0700, Ammar Faizi wrote:
> I would say always using operand-size is our habit in writing Assembly code.
"our" is who?
> Especially for the Linux kernel. Looking at entry_64.S, entry_32.S and many
> Assembly files here, we always use the operand-size. It also helps to determine
> the size quickly.
When do you ever need to determine the operand size quickly?
> It gives us extra information about the operand size when
> sometimes it can be vague.
So I'm looking at output of
objdump -d arch/x86/entry/entry_64.o
and it does by default add suffixes when it is not perfectly clear what
the operand size is, for example:
6a 2b pushq $0x2b
vs
41 51 push %r9
so I think the default of not explicitly adding suffixes when it is
clear what size it is, is the most optimal one.
> I don't think it's that urgent to have, but having it should not bother people
> who don't care with the operand-size suffix anyway.
So I'd prefer if this were a command line option which turns this on
only for whoever absolutely needs it.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2022-03-01 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 4:11 Ammar Faizi
2022-03-01 8:41 ` Borislav Petkov
2022-03-01 9:16 ` Ammar Faizi
2022-03-01 10:44 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh35BQrhlus2uCca@nazgul.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=dave.hansen@linux.intel.com \
--cc=gwml@vger.gnuweeb.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tools@linux.kernel.org \
--cc=weidonghui@allwinnertech.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®