From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA66C433F5 for ; Tue, 1 Mar 2022 08:41:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233463AbiCAImi (ORCPT ); Tue, 1 Mar 2022 03:42:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233446AbiCAImd (ORCPT ); Tue, 1 Mar 2022 03:42:33 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A293588B04 for ; Tue, 1 Mar 2022 00:41:52 -0800 (PST) Received: from nazgul.tnic (dynamic-002-247-255-128.2.247.pool.telefonica.de [2.247.255.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 0F6081EC0531; Tue, 1 Mar 2022 09:41:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1646124106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=fv/wsRJ+/2kkhDuBlBBli91a0adPA17Sg0dPsAfIbxY=; b=HGDxqWIu/qkSwkTdKw5GUczVrJQWtfFWf2W5viNl+J+6ZMgufvZdSkRwNGF9fE5K/ntTLM 50TQ23eOIjh54Rq1YxZMXUrTR74kuPuzuweIaCmZgg1exunrx8prxwh74NbZ9FF1aRLfqg uYctWPRdhuBaRUXCfrx+ghws46a2h5w= Date: Tue, 1 Mar 2022 09:41:50 +0100 From: Borislav Petkov To: Ammar Faizi Cc: weidonghui , tools@linux.kernel.org, linux-kernel@vger.kernel.org, gwml@vger.gnuweeb.org, x86@kernel.org, Andrew Morton , Andy Lutomirski , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner Subject: Re: [PATCH] scripts/decodecode: Make objdump always use operand-size suffix Message-ID: References: <20220301041119.55085-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220301041119.55085-1-ammarfaizi2@gnuweeb.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 01, 2022 at 11:11:19AM +0700, Ammar Faizi wrote: > For better reading, always use operand-size suffix for the generated What does "better reading" mean here exactly? See, there's a reason why -M suffix is not default in objdump. And in my experience, I've never looked at objdump output and thought, "hm, so the operand size insn mnemonic suffix is missing here". And if at all, one usually wants to know the operand size of a single instruction - not the whole bunch - and for that we tend to look at the vendor manuals directly... So I don't think this brings any improvement to the output but hey, I could be missing a reason. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette