From: Andrew Lunn <andrew@lunn.ch>
To: Heyi Guo <guoheyi@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Joel Stanley <joel@jms.id.au>,
Guangbin Huang <huangguangbin2@huawei.com>,
Hao Chen <chenhao288@hisilicon.com>,
Arnd Bergmann <arnd@arndb.de>,
Dylan Hung <dylan_hung@aspeedtech.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers/net/ftgmac100: fix DHCP potential failure with systemd
Date: Wed, 23 Feb 2022 11:48:10 +0100 [thread overview]
Message-ID: <YhYQ6jGQv39rSsDU@lunn.ch> (raw)
In-Reply-To: <20220223031436.124858-4-guoheyi@linux.alibaba.com>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index c1deb6e5d26c5..d5356db7539a4 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -1402,8 +1402,17 @@ static void ftgmac100_adjust_link(struct net_device *netdev)
> /* Disable all interrupts */
> iowrite32(0, priv->base + FTGMAC100_OFFSET_IER);
>
> - /* Reset the adapter asynchronously */
> - schedule_work(&priv->reset_task);
> + /* Release phy lock to allow ftgmac100_reset to aquire it, keeping lock
> + * order consistent to prevent dead lock.
> + */
> + if (netdev->phydev)
> + mutex_unlock(&netdev->phydev->lock);
No need to do this test. The fact that adjust_link is being called
indicates there must be a PHY.
Andrew
next prev parent reply other threads:[~2022-02-23 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 3:14 [PATCH 0/3] drivers/net/ftgmac100: fix occasional DHCP failure Heyi Guo
2022-02-23 3:14 ` [PATCH 1/3] drivers/net/ftgmac100: refactor ftgmac100_reset_task to enable direct function call Heyi Guo
2022-02-23 3:14 ` [PATCH 2/3] drivers/net/ftgmac100: adjust code place for function call dependency Heyi Guo
2022-02-23 3:14 ` [PATCH 3/3] drivers/net/ftgmac100: fix DHCP potential failure with systemd Heyi Guo
2022-02-23 5:00 ` Florian Fainelli
2022-02-23 11:39 ` Heyi Guo
2022-02-23 17:55 ` Florian Fainelli
2022-02-23 18:05 ` Florian Fainelli
2022-02-24 2:52 ` Heyi Guo
2022-02-23 10:48 ` Andrew Lunn [this message]
2022-02-23 11:40 ` Heyi Guo
2022-02-23 13:20 ` [PATCH 0/3] drivers/net/ftgmac100: fix occasional DHCP failure patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhYQ6jGQv39rSsDU@lunn.ch \
--to=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=dylan_hung@aspeedtech.com \
--cc=guoheyi@linux.alibaba.com \
--cc=huangguangbin2@huawei.com \
--cc=joel@jms.id.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®