From: Dominik Brodowski <linux@dominikbrodowski.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] random: cleanup UUID handling
Date: Fri, 25 Feb 2022 08:05:43 +0100 [thread overview]
Message-ID: <Yhh/x2C0b8QvTm2N@owl.dominikbrodowski.net> (raw)
In-Reply-To: <20220224220958.93263-1-Jason@zx2c4.com>
Am Thu, Feb 24, 2022 at 11:09:58PM +0100 schrieb Jason A. Donenfeld:
> Rather than hard coding various lengths, we can use the right constants.
> Strings should be `char *` while buffers should be `u8 *`. Rather than
> have a nonsensical and unused maxlength, just remove it. Finally, use
> snprintf instead of sprintf, just out of good hygiene.
>
> Cc: Dominik Brodowski <linux@dominikbrodowski.net>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Thanks,
Dominik
next prev parent reply other threads:[~2022-02-25 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 22:09 Jason A. Donenfeld
2022-02-25 7:05 ` Dominik Brodowski [this message]
2022-02-25 13:37 ` [PATCH v2] " Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yhh/x2C0b8QvTm2N@owl.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®