From: Greg KH <gregkh@linuxfoundation.org>
To: Yusuf Khan <yusisamerican@gmail.com>
Cc: linux-kernel@vger.kernel.org, jasowang@redhat.com,
mikelley@microsoft.com, mst@redhat.com, javier@javigon.com,
arnd@arndb.de, will@kernel.org, axboe@kernel.dk,
bjorn.andersson@linaro.org
Subject: Re: [PATCH v2] drivers: ddcci: upstream DDCCI driver
Date: Sat, 26 Feb 2022 08:34:17 +0100 [thread overview]
Message-ID: <YhnX+Shp7nRkbvSG@kroah.com> (raw)
In-Reply-To: <20220226040429.1035368-1-yusisamerican@gmail.com>
On Fri, Feb 25, 2022 at 08:04:29PM -0800, Yusuf Khan wrote:
> This patch upstreams the DDCCI driver by Christoph Grenz into
> the kernel. The original gitlab page is loacted at https://gitlab
> .com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master.
>
> Signed-off-by: Yusuf Khan <yusisamerican@gmail.com>
> ---
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/ddcci/Kconfig | 5 +
> drivers/ddcci/Makefile | 3 +
> drivers/ddcci/ddcci-backlight.c | 411 +++++++
> drivers/ddcci/ddcci.c | 1887 +++++++++++++++++++++++++++++++
> include/linux/ddcci.h | 164 +++
Also, you create a lot of sysfs files here, yet document none of them in
Documentation/ABI/ which will make tools like scripts/get_abi.pl
unhappy. Please fix that in your next submission.
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-26 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 4:04 Yusuf Khan
2022-02-26 7:25 ` Greg KH
2022-02-26 7:26 ` Greg KH
2022-02-26 7:34 ` Greg KH [this message]
2022-02-26 8:17 ` kernel test robot
2022-02-26 8:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhnX+Shp7nRkbvSG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=bjorn.andersson@linaro.org \
--cc=jasowang@redhat.com \
--cc=javier@javigon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mst@redhat.com \
--cc=will@kernel.org \
--cc=yusisamerican@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®