From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30EB6C433FE for ; Mon, 14 Mar 2022 10:02:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238194AbiCNKDr (ORCPT ); Mon, 14 Mar 2022 06:03:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232273AbiCNKDl (ORCPT ); Mon, 14 Mar 2022 06:03:41 -0400 Received: from the.earth.li (the.earth.li [IPv6:2a00:1098:86:4d:c0ff:ee:15:900d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C1D537ABD; Mon, 14 Mar 2022 03:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=earth.li; s=the; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GMRm70IRJ3DPdDAQd7rMaNIYMjmW5VYnvTf7K/KQIYQ=; b=U5N1VFVDe80FOaeIDdd17u8TFT MhyUOzbd8/jOQ76yrdHMZk9XbAYGKQXhILyC0h7sfwj1eqbRoHSU9Je8Dc4Ld39qMBXddZ2yxnGpw XmiV9Pn5phcS5tGHViuUc+FbhR4ub7adiw0/cipImjzl6mFqgLr/C5H8+03XtSmJF0XkeiOBwdZHE wBNuuDvPdtcWoVMyEC0sGLrR7eiGePzNjOv+GAk/gl9rndycSHuSHNBcsmrOeiuepa/nofsMwrUvj xPxvqIJM595r7AKn0qEPmAFRd5hTlR+WV6g6ebRXHZznDN0GX1Zy5Rw3/BRBuQTlsDIAowawVHbAV yNrONV0g==; Received: from noodles by the.earth.li with local (Exim 4.94.2) (envelope-from ) id 1nThWv-009O7y-JT; Mon, 14 Mar 2022 10:02:21 +0000 Date: Mon, 14 Mar 2022 10:02:21 +0000 From: Jonathan McDowell To: Bjorn Andersson Cc: Andy Gross , Ansuel Smith , Michael Turquette , Stephen Boyd , Rob Herring , Philipp Zabel , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 15/15] ARM: dts: qcom: add syscon and cxo/pxo clock to gcc node for ipq8064 Message-ID: References: <20220226135235.10051-1-ansuelsmth@gmail.com> <20220226135235.10051-16-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220226135235.10051-16-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org AFAICT the rest of the series has been picked up in clk-for-5.18, but I don't see this there or in dts-for-5.18. It's required for a functioning tsens driver on IPQ8064 so it would be nice to see it landed. On Sat, Feb 26, 2022 at 02:52:35PM +0100, Ansuel Smith wrote: > Add syscon compatible required for tsens driver to correctly probe driver > and access the reg. Also add cxo and pxo tag and declare them as gcc clock > now requires them for the ipq8064 gcc driver that has now been modernized. > > Signed-off-by: Ansuel Smith > Reviewed-by: Bjorn Andersson > Reviewed-by: Stephen Boyd > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 11481313bdb6..5524a68cf3d1 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -298,13 +298,13 @@ smem: smem@41000000 { > }; > > clocks { > - cxo_board { > + cxo_board: cxo_board { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <25000000>; > }; > > - pxo_board { > + pxo_board: pxo_board { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <25000000>; > @@ -736,7 +736,9 @@ tsens_calib_backup: calib_backup@410 { > }; > > gcc: clock-controller@900000 { > - compatible = "qcom,gcc-ipq8064"; > + compatible = "qcom,gcc-ipq8064", "syscon"; > + clocks = <&pxo_board>, <&cxo_board>; > + clock-names = "pxo", "cxo"; > reg = <0x00900000 0x4000>; > #clock-cells = <1>; > #reset-cells = <1>; > -- > 2.34.1 > J. -- I program, therefore I am. | .''`. Debian GNU/Linux Developer | : :' : Happy to accept PGP signed | `. `' or encrypted mail - RSA | `- key on the keyservers.