From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9BE3C433F5 for ; Mon, 14 Mar 2022 10:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238747AbiCNLAc (ORCPT ); Mon, 14 Mar 2022 07:00:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233418AbiCNLA1 (ORCPT ); Mon, 14 Mar 2022 07:00:27 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F8BD36B47 for ; Mon, 14 Mar 2022 03:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=86nbLiR0MkBXCOLBGSi53xPDKrTVsOY11BL+JmwuMJY=; b=Ge4R7dvmihFJcEPRq5KCmBbCs2 w2432IoagskBOyKKKKJFNUn5t0sb68FlZLfaUXYuiaXa5IBuoCbFJLGyMUKkXzKBTm0bCuyGhRv9A VrcL5TOJqkGRsvliRB1mjhwLZQ/PelJ/wH/Q9RMDBm1pBJLJOyyEplQszhLp/elvjcy23PTw3CTAb 1CvKBrf3debS0xkw06Bm8jdCQJvjx7ymDhKQs9JVG2CdT5N9DYIw7OaZazgHllnwJSZQr/r4TzAXH YQVNxtR9XKClf7hgIOiFUqbGXPXndje8UagfWeUqEpyTSSKS9p6SDv58TWpE7D5aJJ8R7QtuB57CQ jrDGS8AA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTiPm-003xgm-Hh; Mon, 14 Mar 2022 10:59:02 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 032983001FD; Mon, 14 Mar 2022 11:59:01 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id DD23933FA5132; Mon, 14 Mar 2022 11:59:00 +0100 (CET) Date: Mon, 14 Mar 2022 11:59:00 +0100 From: Peter Zijlstra To: Jiri Kosina Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/nmi: Remove the 'strange power saving mode' hint from unknown NMI handler Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 14, 2022 at 09:25:18AM +0100, Jiri Kosina wrote: > From: Jiri Kosina > > The 'Do you have a strange power saving mode enabled?' hint when unknown > NMI happens dates back to i386 stone age, and isn't currently really > helpful. > > Unknown NMIs are coming for many different reasons (broken firmware, > faulty hardware, ...) and rarely have anything to do with 'strange power > saving mode' (whatever that even is). > > Just remove it as it's largerly misleading. > > Signed-off-by: Jiri Kosina Fair enough, Acked-by: Peter Zijlstra (Intel) > --- > arch/x86/kernel/nmi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c > index 4bce802d25fb..e73f7df362f5 100644 > --- a/arch/x86/kernel/nmi.c > +++ b/arch/x86/kernel/nmi.c > @@ -292,7 +292,6 @@ unknown_nmi_error(unsigned char reason, struct pt_regs *regs) > pr_emerg("Uhhuh. NMI received for unknown reason %02x on CPU %d.\n", > reason, smp_processor_id()); > > - pr_emerg("Do you have a strange power saving mode enabled?\n"); > if (unknown_nmi_panic || panic_on_unrecovered_nmi) > nmi_panic(regs, "NMI: Not continuing"); > > -- > Jiri Kosina > SUSE Labs >