From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D26C3C433F5 for ; Mon, 14 Mar 2022 16:03:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234237AbiCNQE0 (ORCPT ); Mon, 14 Mar 2022 12:04:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240452AbiCNQEQ (ORCPT ); Mon, 14 Mar 2022 12:04:16 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A78823BE5 for ; Mon, 14 Mar 2022 09:02:59 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id 15-20020a17090a098f00b001bef0376d5cso15058017pjo.5 for ; Mon, 14 Mar 2022 09:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1iT022fIKxpXmN8c755nbteZp5bmgr4mJqOC9s4pU+M=; b=YszkTIZuKwUzUrrO+088AWNuLXa2SqygoFgan2PIzRf2h5EM5YACyz09I77TN17p7t iZ/DsI06OGIiSEZA/I6LCxli0z0BVOJKcxfgnjjwMNc/Aw9WH9P21BTqg226W7WucAfY ZHWnzr9RhTur1ZHdsMdDU8kx4KivbhdhdgJ1sKjhlgitHmo7StU62OhJV7XOCEcaPvIq DIL/30bX/kiyeDLz3IeMWagJa+RJDRVtQsIRQZEZZNmGF3ogfExSKQFWO4MElDqetSfB 7nRnQbBBND8SLmdU7s93FEzLiOeR5hCbrutJRfrZGneG1S09q9ul0C2U/Mk6VsMz6A4w vbMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=1iT022fIKxpXmN8c755nbteZp5bmgr4mJqOC9s4pU+M=; b=tX3dTxdeFh0dcu4ySTTTaz4nPNOqa4jLVy3BwN4poPUj7iH4EOJFdX/4UneGPLZNSG 3qX1G4Mjcv8NHQ4prerKnHvvrl0iZ7WGy1qdydh3bdQWrrFDZIpdKaSUAib45emsXIoA bwaL277klDbZwVFyTtxGaFtttjAGFSXR5NYTMu5XCkKnxWWKYncAEHmOgJS9GVYkmcw0 hQOFUnfjuHiyqOc/KTBmJPeseXjjybes9B9qgSKHGUyoAC4EvVWBDNwDJVib6nlJ88p7 0Ql8Jnt6X1+PVfC59ru2kCXjlXeRox+e4Sl081lgkncLp4HMkcXn+lafX2ozHedMOIdi h4ig== X-Gm-Message-State: AOAM532CRAtKFN11kQFV3cZNdS5Z8xRxj0PLuZ9HVdX7hCWSWXb+f6uh Hf47hySHGbPVbiQmYuwj7tM= X-Google-Smtp-Source: ABdhPJy2IzCO66f+V0fQdvwZ7Wl67owDcFCFksRCr/5jDaScEoqgLkTZGGxohQrvNOubydApI9cKfw== X-Received: by 2002:a17:90b:1c03:b0:1bf:5720:f8a1 with SMTP id oc3-20020a17090b1c0300b001bf5720f8a1mr25979428pjb.100.1647273778648; Mon, 14 Mar 2022 09:02:58 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-e24f-43ff-fee6-449f.res6.spectrum.com. [2603:800c:1a02:1bae:e24f:43ff:fee6:449f]) by smtp.gmail.com with ESMTPSA id g6-20020a056a001a0600b004f7bd56cc08sm6375600pfv.123.2022.03.14.09.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 09:02:58 -0700 (PDT) Sender: Tejun Heo Date: Mon, 14 Mar 2022 06:02:56 -1000 From: Tejun Heo To: Rasmus Villemoes Cc: "Eric W. Biederman" , Andrew Morton , Petr Mladek , David Hildenbrand , Yafang Shao , Cai Huoqing , linux-kernel@vger.kernel.org Subject: Re: [PATCH] linux/kthread.h: remove unused macros Message-ID: References: <20220314145343.494694-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220314145343.494694-1-linux@rasmusvillemoes.dk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 14, 2022 at 03:53:42PM +0100, Rasmus Villemoes wrote: > Ever since these macros were introduced in commit b56c0d8937e6 > ("kthread: implement kthread_worker"), there has been precisely one > user (commit 4d115420707a, "NVMe: Async IO queue deletion"), and that > user went away in 2016 with db3cbfff5bcc ("NVMe: IO queue deletion > re-write"). > > Apart from being unused, these macros are also awkward to use (which > may contribute to them not being used): Having a way to statically (or > on-stack) allocating the storage for the struct kthread_worker itself > doesn't help much, since obviously one needs to have some code for > actually _spawning_ the worker thread, which must have error > checking. And these days we have the kthread_create_worker() interface > which both allocates the struct kthread_worker and spawns the kthread. > > Signed-off-by: Rasmus Villemoes Acked-by: Tejun Heo Thanks. -- tejun