From: Greg KH <gregkh@linuxfoundation.org>
To: Jianglei Nie <niejianglei2021@163.com>
Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: vt: consolemap: Add missing kfree() in con_do_clear_unimap()
Date: Thu, 3 Mar 2022 08:37:25 +0100 [thread overview]
Message-ID: <YiBwNUPTm8zR2BEU@kroah.com> (raw)
In-Reply-To: <20220303020630.460257-1-niejianglei2021@163.com>
On Thu, Mar 03, 2022 at 10:06:30AM +0800, Jianglei Nie wrote:
> We should free p after con_release_unimap(p) like the call points of
> con_release_unimap() do in the same file.
>
> This patch adds the missing kfree() after con_release_unimap(p).
>
> Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
> ---
> drivers/tty/vt/consolemap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c
> index d815ac98b39e..5279c3d27720 100644
> --- a/drivers/tty/vt/consolemap.c
> +++ b/drivers/tty/vt/consolemap.c
> @@ -520,6 +520,7 @@ static int con_do_clear_unimap(struct vc_data *vc)
> p->refcount++;
> p->sum = 0;
> con_release_unimap(p);
> + kfree(p);
> }
> return 0;
> }
> --
> 2.25.1
>
How did you test this code?
next prev parent reply other threads:[~2022-03-03 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 2:06 Jianglei Nie
2022-03-03 7:37 ` Greg KH [this message]
[not found] ` <4a7fe3ca.68b6.17f6eacb952.Coremail.niejianglei2021@163.com>
2022-03-09 13:40 ` Greg KH
2022-04-22 13:44 ` Greg KH
2022-04-25 6:59 ` Jiri Slaby
2022-04-25 7:09 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiBwNUPTm8zR2BEU@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niejianglei2021@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®