From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE09C433FE for ; Fri, 4 Mar 2022 14:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239983AbiCDOyl (ORCPT ); Fri, 4 Mar 2022 09:54:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237899AbiCDOyj (ORCPT ); Fri, 4 Mar 2022 09:54:39 -0500 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EF30187E39; Fri, 4 Mar 2022 06:53:51 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id A78341BF204; Fri, 4 Mar 2022 14:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646405630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TySVdy94IbkIuYNoa5NXDfUiMMMbAJCyvZocHTXJLaQ=; b=JUTYSelu7xdSqVX75hDUcp8cIxwmHcv9hcdi+qKwFwZwwF9ZcswDHPNDri4vFA/nmhbPxn zYUm/OokbkkmGlSzX0W1BDM0vYILIyMkFFjSeQXT1qZ52phCZCv1pZe061AFK/NTr8laQu Alt77bfdW0/V4bA3W+kn0EGb83xDde01AF1r0x/V/6S8GTHlZvClDu4uxBsZCy8qag2B2a +EajNCUcmd839e48K8ycbiqefS8XC+MRjz1MOCF8FCfpZGFXyA+QYe3zYEXtDeRBoRWA6p xqOBY40MWUksV8Gke9Ji3wMwFPhCEBssJIIVzQiIvZV399HO96khPZSrXBeekQ== Date: Fri, 4 Mar 2022 15:53:48 +0100 From: Alexandre Belloni To: Sergiu Moga Cc: a.zummo@towertech.it, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, nicolas.ferre@microchip.com, claudiu.beznea@microchip.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] ARM: dts: at91: Add the required `atmel,rtt-rtc-time-reg` property Message-ID: References: <20220304142746.121947-1-sergiu.moga@microchip.com> <20220304142746.121947-2-sergiu.moga@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220304142746.121947-2-sergiu.moga@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2022 16:27:42+0200, Sergiu Moga wrote: > Add the required `atmel,rtt-rtc-time-reg` property to the `rtt` nodes > of the board files that were missing it. > > Signed-off-by: Sergiu Moga > --- > arch/arm/boot/dts/at91sam9261ek.dts | 4 ++++ > arch/arm/boot/dts/at91sam9263ek.dts | 8 ++++++++ > arch/arm/boot/dts/at91sam9rlek.dts | 4 ++++ > 3 files changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/at91sam9261ek.dts b/arch/arm/boot/dts/at91sam9261ek.dts > index beed819609e8..3c1f40b4a13e 100644 > --- a/arch/arm/boot/dts/at91sam9261ek.dts > +++ b/arch/arm/boot/dts/at91sam9261ek.dts > @@ -178,6 +178,10 @@ dbgu: serial@fffff200 { > status = "okay"; > }; > > + rtc@fffffd20 { > + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > + }; > + > watchdog@fffffd40 { > status = "okay"; > }; > diff --git a/arch/arm/boot/dts/at91sam9263ek.dts b/arch/arm/boot/dts/at91sam9263ek.dts > index 71f60576761a..1208bb580d14 100644 > --- a/arch/arm/boot/dts/at91sam9263ek.dts > +++ b/arch/arm/boot/dts/at91sam9263ek.dts > @@ -102,6 +102,14 @@ mtd_dataflash@0 { > }; > }; > > + rtc@fffffd20 { > + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > + }; > + > + rtc@fffffd50 { > + atmel,rtt-rtc-time-reg = <&gpbr 0x4>; > + }; Do we really need two RTCs with the exact same features on that board? Is there a check failure hen the property is not there and the node is disabled? -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com