mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: dann frazier <dann.frazier@canonical.com>
Cc: stable@vger.kernel.org, Miao Xie <miaox@cn.fujitsu.com>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Barry Song <song.bao.hua@hisilicon.com>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Sergei Trofimovich <slyfox@gentoo.org>,
	Anatoly Pugachev <matorola@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5.10+5.4 0/3] sched/topology: Fix missing scheduling domain levels
Date: Sat, 5 Mar 2022 20:50:42 +0100	[thread overview]
Message-ID: <YiO/EsBd0QlDA9o4@kroah.com> (raw)
In-Reply-To: <20220305164430.245125-1-dann.frazier@canonical.com>

On Sat, Mar 05, 2022 at 09:44:27AM -0700, dann frazier wrote:
> The LTP cpuset_sched_domains test, authored by Miao Xie, fails on a Kunpeng920
> server that has 4 NUMA nodes:
>   https://launchpad.net/bugs/1951289
> 
> This does appear to be a real bug. /proc/schedstat displays 4 domain levels for
> CPUs on 2 of the nodes, but only 3 levels for the others 2 (see below).
> I assume this means the scheduler is making suboptimal decisions about
> where to place/move processes. I'm not sure how to demonstrate that - but
> open to suggestions if that evidence is important justification for stable.
> 
> This is not a problem in current upstream kernels, so I bisected and found
> that the first patch here fixes it. I can't tell from the commit message
> if fixing this case was Valentin's intent, or just a happy side-effect of the
> set conversion. The other two patches fix regressions introduced by the first.
> All cherry-pick cleanly back to 5.10.y and 5.4.y. This platform easily
> reproduces the problem Dietmar's fix addresses. I don't have hardware to test
> the ia64 fix.
> 
> Note: This also impacts earlier stable trees, but require some minor porting,
> so I'll submit fixes for those separately.
> 
> Here's a comparison of /proc/schedstat before & after applying these
> fixes:

Thanks, now queued up.

greg k-h

      parent reply	other threads:[~2022-03-05 19:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-05 16:44 dann frazier
2022-03-05 16:44 ` [PATCH 5.10+5.4 1/3] sched/topology: Make sched_init_numa() use a set for the deduplicating sort dann frazier
2022-03-05 16:44 ` [PATCH 5.10+5.4 2/3] sched/topology: Fix sched_domain_topology_level alloc in sched_init_numa() dann frazier
2022-03-05 17:13   ` Joe Perches
2022-03-05 17:25     ` Joe Perches
2022-03-05 16:48 ` [PATCH 5.10+5.4 3/3] ia64: ensure proper NUMA distance and possible map initialization dann frazier
2022-03-05 19:50 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiO/EsBd0QlDA9o4@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=dann.frazier@canonical.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matorola@gmail.com \
    --cc=miaox@cn.fujitsu.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=slyfox@gentoo.org \
    --cc=song.bao.hua@hisilicon.com \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®