From: "Niklas Söderlund" <niklas.soderlund@corigine.com>
To: Guo Zhengkui <guozhengkui@vivo.com>
Cc: Simon Horman <simon.horman@corigine.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Louis Peens <louis.peens@corigine.com>,
Yinjun Zhang <yinjun.zhang@corigine.com>,
Paolo Abeni <pabeni@redhat.com>,
"open list:NETRONOME ETHERNET DRIVERS" <oss-drivers@corigine.com>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD
Date: Mon, 7 Mar 2022 10:27:10 +0100 [thread overview]
Message-ID: <YiXP7i/tSLpdzM3+@bismarck.dyn.berto.se> (raw)
In-Reply-To: <20220307090804.4821-1-guozhengkui@vivo.com>
Hi Guo,
Thanks for your work.
On 2022-03-07 17:07:59 +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 00a09b9e0aee..d5ff80a62882 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -3431,7 +3431,7 @@ nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp,
>
> if (xsk_pool_get_rx_frame_size(dp->xsk_pools[r]) < xsk_min_fl_bufsz) {
> NL_SET_ERR_MSG_MOD(extack,
> - "XSK buffer pool chunk size too small\n");
> + "XSK buffer pool chunk size too small");
> return -EINVAL;
> }
> }
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2022-03-07 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 9:07 Guo Zhengkui
2022-03-07 9:27 ` Niklas Söderlund [this message]
2022-03-07 12:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiXP7i/tSLpdzM3+@bismarck.dyn.berto.se \
--to=niklas.soderlund@corigine.com \
--cc=davem@davemloft.net \
--cc=guozhengkui@vivo.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®