From: Mark Brown <broonie@kernel.org>
To: Alifer Moraes <alifer.m@variscite.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, eran.m@variscite.com,
festevam@gmail.com, lgirdwood@gmail.com,
linuxppc-dev@lists.ozlabs.org, nicoleotsuka@gmail.com,
patches@opensource.cirrus.com, perex@perex.cz,
pierluigi.p@variscite.com, robh+dt@kernel.org,
shengjiu.wang@gmail.com, tiwai@suse.com, Xiubo.Lee@gmail.com
Subject: Re: [PATCH 4/4] ASoC: wm8904: add DMIC support
Date: Mon, 7 Mar 2022 16:25:47 +0000 [thread overview]
Message-ID: <YiYyC1MVd+oCMU4x@sirena.org.uk> (raw)
In-Reply-To: <20220307141041.27538-4-alifer.m@variscite.com>
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
On Mon, Mar 07, 2022 at 11:10:41AM -0300, Alifer Moraes wrote:
> +static const char *cin_text[] = {
> + "ADC", "DMIC"
> +};
> +
> +static SOC_ENUM_SINGLE_DECL(cin_enum,
> + WM8904_DIGITAL_MICROPHONE_0, 12, cin_text);
Why would this be runtime selectable? I'd expect the decision to use
an analogue or digital microphone to be made in the hardware design.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-07 16:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 14:10 [PATCH 1/4] ASoC: fsl-asoc-card: add WM8904 support Alifer Moraes
2022-03-07 14:10 ` [PATCH 2/4] ASoC: bindings: fsl-asoc-card: Add compatible string for wm8904 Alifer Moraes
2022-03-07 14:10 ` [PATCH 3/4] ASoC: wm8904: extend device tree support Alifer Moraes
2022-03-07 16:16 ` Mark Brown
2022-03-10 20:51 ` Rob Herring
2022-06-20 14:39 ` Pierluigi Passaro
2022-03-07 14:10 ` [PATCH 4/4] ASoC: wm8904: add DMIC support Alifer Moraes
2022-03-07 16:25 ` Mark Brown [this message]
2022-06-20 19:53 ` Pierluigi Passaro
2022-06-21 13:11 ` Mark Brown
2022-03-11 17:16 ` [PATCH 1/4] ASoC: fsl-asoc-card: add WM8904 support Mark Brown
2022-06-20 14:49 [PATCH 4/4] ASoC: wm8904: add DMIC support Pierluigi Passaro
2022-06-20 14:56 ` Mark Brown
2022-06-20 15:03 Pierluigi Passaro
2022-06-20 15:09 ` Mark Brown
2022-06-20 15:30 Pierluigi Passaro
2022-06-20 17:38 ` Mark Brown
2022-06-20 17:52 Pierluigi Passaro
2022-06-20 18:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiYyC1MVd+oCMU4x@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alifer.m@variscite.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=eran.m@variscite.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=pierluigi.p@variscite.com \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®