From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FA0C433F5 for ; Tue, 8 Mar 2022 12:23:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346697AbiCHMYB (ORCPT ); Tue, 8 Mar 2022 07:24:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346785AbiCHMXu (ORCPT ); Tue, 8 Mar 2022 07:23:50 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5BDD3A5D4; Tue, 8 Mar 2022 04:22:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646742173; x=1678278173; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1t2XizitfaB4uMPTTPoQH/R4rBfgRMQMND9uM6rWnHc=; b=naEmr/76iul9yOsCW7wuj4uOKfeoOlGNacDQgsTEINfrouvqEqwgC87z 5ipRNYzOg4PQcW8Djqal/IllHtrrEJnYuJIyKXzrfWwWjg200hkYRApss WrgLlIyRTGY4IiMvFoAYHQw6Bv0+1SPpMdfhkRA44TYBL8kUdOV91uGOn 4cEJzuXg27WGZQkdr0ddr7fKMuEuA7SIzhx38K8iLr8pNldtG5yiFSb3/ KbHco50hUOSN5vQQNxkIqNkyBh/FwIcabzGuOG65iqdnxMBuLibrjj8+b H53XXqLZ8YddFmmsHsEHtvVPop82VX4LrOcGlnyumwU0f8axZEgQHcmM0 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="279384013" X-IronPort-AV: E=Sophos;i="5.90,164,1643702400"; d="scan'208";a="279384013" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2022 04:22:53 -0800 X-IronPort-AV: E=Sophos;i="5.90,164,1643702400"; d="scan'208";a="632215878" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2022 04:22:50 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nRYqs-00DLqR-NQ; Tue, 08 Mar 2022 14:22:06 +0200 Date: Tue, 8 Mar 2022 14:22:06 +0200 From: Andy Shevchenko To: Sakari Ailus Cc: "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Scally , Heikki Krogerus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , Nuno =?iso-8859-1?Q?S=E1?= Subject: Re: [PATCH v3 1/1] device property: Allow error pointer to be passed to fwnode APIs Message-ID: References: <20220307202949.75300-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 08, 2022 at 01:15:22PM +0200, Sakari Ailus wrote: > Hi Andy, > > This makes secondary handling quite a big nicer, thanks! You are welcome! > A few comments below. Apart from that, > > Reviewed-by: Sakari Ailus Thanks! ... > On Mon, Mar 07, 2022 at 10:29:49PM +0200, Andy Shevchenko wrote: > > #include > > #include > > +#include > > Is this intended? linux/property.h already includes linux/fwnode.h. > > > #include > > #include > > #include Yeah, this is a bit messy in the headers. I will drop the inclusion, but in the future it would be good to reshuffle property.h, fwnode.h, and perhaps extract swnode.h. ... > > bool ret; > > > > + if (IS_ERR_OR_NULL(fwnode)) > > + return false; > > + if (ret == true) > > It's already bool. I'd instead use: > > if (ret) Right, will amend this. > > + return ret; -- With Best Regards, Andy Shevchenko