From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 969ABC433F5 for ; Wed, 9 Mar 2022 15:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233630AbiCIPaP (ORCPT ); Wed, 9 Mar 2022 10:30:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232197AbiCIPaN (ORCPT ); Wed, 9 Mar 2022 10:30:13 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77F93D4C8D for ; Wed, 9 Mar 2022 07:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5RgX5tZLSsAtO9xXtxg7N8PS6/VOcsvGlxTOVBEJBiM=; b=IIm9rfkLwI0uUdNY/9J8RWA0Mj MHDmjb4uDI+o59odgPocvlaFEGFxkzkdE0jg6Whr093gioLjaDo8EhFWiXjp9m29xSmxWV9gjHRBZ Ltj3327XbxYtmXa+lpV9PsOd8Bc4BSpZuGdyNYGOBEBGet6DvgQ3hwiaFgusrkBS4lNregjBX6B+p JWyMVASql6a7M6QxATsuSChFlxygafIlSkhO2Aqg8eJo4FS4kiujDeFkjq9CL1qJNW5Gm0BWEINrd ddQVsh5E2GdGyqTG59E3pNkuTg854nMNSpiWcJ3fFz/mItx4PishD+b+D1QYj8OJJ9OD0yKo6x+Ts VNhjlusA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRyF5-00HEaa-UG; Wed, 09 Mar 2022 15:28:48 +0000 Date: Wed, 9 Mar 2022 15:28:47 +0000 From: Matthew Wilcox To: sxwjean@me.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, longman@redhat.com, guro@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiongwei Song Subject: Re: [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab_page() Message-ID: References: <20220309145052.219138-1-sxwjean@me.com> <20220309145052.219138-3-sxwjean@me.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309145052.219138-3-sxwjean@me.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2022 at 10:50:52PM +0800, sxwjean@me.com wrote: > From: Xiongwei Song > > The parameter @s is useless for alloc_slab_page(), let's delete it. Perhaps we could add a little more information here. It was added in 2014 by 5dfb41750992 ("sl[au]b: charge slabs to kmemcg explicitly"). The need for it was removed in 2020 by 1f3147b49d75 ("mm: slub: call account_slab_page() after slab page initialization"). Reviewed-by: Matthew Wilcox (Oracle)