From: Mark Brown <broonie@kernel.org>
To: John Keeping <john@metanate.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Daniel Beer <daniel.beer@igorinstitute.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: tas5805m: fix pdn polarity
Date: Wed, 9 Mar 2022 15:56:12 +0000 [thread overview]
Message-ID: <YijOHNT0eqDyoviP@sirena.org.uk> (raw)
In-Reply-To: <20220309135649.195277-1-john@metanate.com>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Wed, Mar 09, 2022 at 01:56:49PM +0000, John Keeping wrote:
> The binding defines the GPIO as "pdn-gpios" so when the GPIO is active
> the expectation is that the power down signal is asserted and this is
> how all other drivers using this GPIO name interpret the value.
> But the tas5805m driver inverts the sense from the normal expectation so
> when the powerdown GPIO is logically asserted the chip is running.
> This is a new driver that is not yet in a released kernel and has no
> in-tree users of the binding so fix the sense of the GPIO so that
> logically asserted means that the device is powered down.
> - Rewrite commit message to make it more obvious that this is a change
> to the interpretation of the GPIO in the binding
I'm still not seeing the functional change here. The actual state of
the GPIO is identical in both cases, all that's changing is the logical
view internally to the kernel.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-09 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 13:56 John Keeping
2022-03-09 15:56 ` Mark Brown [this message]
2022-03-09 16:19 ` John Keeping
2022-03-09 16:28 ` Mark Brown
2022-03-09 20:16 ` John Keeping
2022-03-09 21:55 ` Mark Brown
2022-03-10 20:09 ` John Keeping
2022-03-11 12:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YijOHNT0eqDyoviP@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=daniel.beer@igorinstitute.com \
--cc=john@metanate.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®