From: Mark Brown <broonie@kernel.org>
To: "Sa, Nuno" <Nuno.Sa@analog.com>
Cc: Steve Lee <steve.lee.analog@gmail.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"rf@opensource.wolfsonmicro.com" <rf@opensource.wolfsonmicro.com>,
"shumingf@realtek.com" <shumingf@realtek.com>,
"srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
"krzk@kernel.org" <krzk@kernel.org>,
"dmurphy@ti.com" <dmurphy@ti.com>,
"jack.yu@realtek.com" <jack.yu@realtek.com>,
"steves.lee@maximintegrated.com" <steves.lee@maximintegrated.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: max98390: Add reset gpio control
Date: Thu, 10 Mar 2022 11:29:16 +0000 [thread overview]
Message-ID: <YinhDPrSvrYV5vKp@sirena.org.uk> (raw)
In-Reply-To: <SJ0PR03MB67794358405FA661992A206D990B9@SJ0PR03MB6779.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On Thu, Mar 10, 2022 at 08:48:09AM +0000, Sa, Nuno wrote:
> > + max98390->reset_gpio = of_get_named_gpio(i2c-
> > >dev.of_node,
> > + "maxim,reset-gpios", 0);
> Why not using devm_gpiod_get_optional()? We could request the pin
> already in the asserted state and make the code slightly better...
Yes, and it'd support other firmware interfaces too. We also need an
update to the binding document covering the new property.
Might also be worth putting the device into reset when unloading the
driver, though that's not essential.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-10 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 8:15 Steve Lee
2022-03-10 8:48 ` Sa, Nuno
2022-03-10 11:29 ` Mark Brown [this message]
2022-03-11 5:53 ` Lee Steve
2022-03-11 5:50 ` Lee Steve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YinhDPrSvrYV5vKp@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Nuno.Sa@analog.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=dmurphy@ti.com \
--cc=geert@linux-m68k.org \
--cc=jack.yu@realtek.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rf@opensource.wolfsonmicro.com \
--cc=shumingf@realtek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=steve.lee.analog@gmail.com \
--cc=steves.lee@maximintegrated.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®