From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/dax: Fix run_dax() missing prototype
Date: Thu, 10 Mar 2022 15:12:21 -0800 [thread overview]
Message-ID: <YiqF1a9VNiSWI5j0@iweiny-desk3> (raw)
In-Reply-To: <CAPcyv4juDzD4W_xAff2CdTFzKQhqfFkn93Zo_4Mw23v+Rq=1+g@mail.gmail.com>
On Wed, Mar 09, 2022 at 09:08:36PM -0800, Dan Williams wrote:
> On Fri, Mar 4, 2022 at 12:38 PM <ira.weiny@intel.com> wrote:
> >
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > The function run_dax() was missing a prototype when compiling with
> > warnings.
> >
> > Add bus.h to fix this.
> >
>
> Always include the warning and the compiler in the changelog.
Sorry.
> I
> suspect you hit this with LLVM and not gcc?
No this was with gcc.
gcc -Wp,-MMD,drivers/dax/.super.o.d -nostdinc -I./arch/x86/include
...
-D__KBUILD_MODNAME=kmod_dax -c -o drivers/dax/super.o drivers/dax/super.c ;
./tools/objtool/objtool orc generate --no-fp --retpoline --uaccess drivers/dax/super.o
drivers/dax/super.c:276:6: warning: no previous prototype for ‘run_dax’ [-Wmissing-prototypes]
276 | void run_dax(struct dax_device *dax_dev)
| ^~~~~~~
>
> super.c has no business including bus.h. If the bots are tripping over
> this a better fix is to move it into dax-private.h.
It was not a bot just me using W=1.
I can ignore it or move the prototype to dax-private.h.
Ira
prev parent reply other threads:[~2022-03-10 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 20:37 ira.weiny
2022-03-10 5:08 ` Dan Williams
2022-03-10 23:12 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiqF1a9VNiSWI5j0@iweiny-desk3 \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®