From: gregkh <gregkh@linuxfoundation.org>
To: Yusuf Khan <yusisamerican@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jason Wang <jasowang@redhat.com>,
Michael Kelley <mikelley@microsoft.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
javier@javigon.com, Arnd Bergmann <arnd@arndb.de>,
Will Deacon <will@kernel.org>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v4] drivers: ddcci: upstream DDCCI driver
Date: Fri, 11 Mar 2022 07:52:07 +0100 [thread overview]
Message-ID: <YirxlzkYxl3MIjoR@kroah.com> (raw)
In-Reply-To: <CAJoG2+8OcL=5RRptaNMhXkFeDragq46_WpHpuN8XEP+jNbdZ0w@mail.gmail.com>
On Thu, Mar 10, 2022 at 05:19:47PM -0800, Yusuf Khan wrote:
> I (hopefully) fulfilled those requests in my subsequent patch,
> turns out I forgot to git add some of my changes. I did not
> remove the unlikely()s as I think they look good and point
> to where error checking is that many may miss.
Never use a unlikely() or likely() macro unless you can prove, with a
benchmark, that it makes the code go faster. If not, just remove them
as the compiler and CPU will always do a better job at this (we have
proof of it in the past.)
thanks,
greg k-h
next prev parent reply other threads:[~2022-03-11 6:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 5:59 Yusuf Khan
2022-03-10 7:13 ` Randy Dunlap
2022-03-11 1:19 ` Yusuf Khan
2022-03-11 6:52 ` gregkh [this message]
2022-03-11 7:24 ` Yusuf Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YirxlzkYxl3MIjoR@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=jasowang@redhat.com \
--cc=javier@javigon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mst@redhat.com \
--cc=rdunlap@infradead.org \
--cc=will@kernel.org \
--cc=yusisamerican@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®