Re: [PATCH] sched: topology: make cache topology separate from cpu topology

[Peter Zijlstra <peterz@infradead.org>]

On Thu, Mar 10, 2022 at 04:58:44AM -0800, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> Some architectures(e.g. ARM64), caches are implemented below:
> cluster:              ****** cluster 0 *****      ****** cluster 1 *****
> core:                 0      1      2      3      4      5      6      7
> cache(Leveln):        **cache0**   **cache1**	 **cache2**   **cache3**
> sd_llc_id(current):   0      0      0      0      4      4      4      4
> sd_llc_id(should be): 0      0      2      2      4      4      6      6
> 
> Caches and cpus have different topology, this causes cpus_share_cache()
> return the wrong value, which will affect the CPU load balance.
> 
> Cache topology should be separated with CPU topology, it can be obtained
> from "next-level-cache" in DTS preferentially.

If your clusters do not have cache, then you're currently setting
SD_SHARE_PKG_RESOURCES wrong, if they do, things are correct.

If you want to represent L2, use the new fangled cluster level or
something, that's what it's there for.

That is, you can represent the above like:

	DIE:	0-7
	MC:	0-3,		4-7
	CLS:	0-1,1-2,	4-5,6-7

But if there is cache at MC, LLC is what it is.